Skip to content

Inherit validation allowances#5382

Merged
rmosolgo merged 1 commit into
rmosolgo:masterfrom
gmac:gmac/inherit_validation_allowances
Jun 11, 2025
Merged

Inherit validation allowances#5382
rmosolgo merged 1 commit into
rmosolgo:masterfrom
gmac:gmac/inherit_validation_allowances

Conversation

@gmac
Copy link
Copy Markdown
Contributor

@gmac gmac commented Jun 11, 2025

The new validation and complexity allowances do not inherit from a base class down to subclasses like other similar settings. This fixes that.

  • Adds inheritance for:
    • allow_legacy_invalid_empty_selections_on_union
    • allow_legacy_invalid_return_type_conflicts
    • complexity_cost_calculation_mode
  • Inheritance tests for each setting.
  • Confirmed no use in hot paths.

@rmosolgo rmosolgo added this to the 2.5.10 milestone Jun 11, 2025
@rmosolgo
Copy link
Copy Markdown
Owner

Thanks for this improvement!

@rmosolgo rmosolgo merged commit 0e092de into rmosolgo:master Jun 11, 2025
13 of 15 checks passed
@gmac gmac deleted the gmac/inherit_validation_allowances branch June 11, 2025 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants