Skip to content

Support dataloader calls after batched lazy resolve#5400

Merged
rmosolgo merged 1 commit into
masterfrom
dataloader-batch-integration
Jul 9, 2025
Merged

Support dataloader calls after batched lazy resolve#5400
rmosolgo merged 1 commit into
masterfrom
dataloader-batch-integration

Conversation

@rmosolgo
Copy link
Copy Markdown
Owner

@rmosolgo rmosolgo commented Jul 8, 2025

Fixes #5399

Previously, the promises were all resolved inside a single fiber, so when a promise led to a Dataloader .load call, that fiber would pause until Dataloader ran. Then that fiber would resume again, make the next .load call, then pause again.

Now, each promise is handled in a separate fiber, so when it calls .load, Dataloader can continue running other fibers (and then it can accumulate other .load calls before running #fetch).

@rmosolgo rmosolgo added this to the 2.5.11 milestone Jul 8, 2025
@rmosolgo rmosolgo merged commit 9e03c13 into master Jul 9, 2025
26 of 29 checks passed
@rmosolgo rmosolgo deleted the dataloader-batch-integration branch July 9, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dataloader source's fetch method called N times via object authorization block

1 participant