Skip to content

Exec-next: Use a single results array to simplify and speed up authorized fields #5607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rmosolgo merged 2 commits into from
Apr 23, 2026
+30 −40
Merged

Exec-next: Use a single results array to simplify and speed up authorized fields #5607

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7913a58
Use a single results array to simplify and speed up authorized fields
rmosolgo Apr 23, 2026
2463bb3
reformat condition for better tracing
rmosolgo Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 30 additions & 40 deletions lib/graphql/execution/field_resolve_step.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ def initialize(parent_type:, runner:, key:, selections_step:)
@all_next_results = nil
@static_type = nil
@next_selections = nil
@object_is_authorized = nil
@results = nil
@finish_extension_idx = nil
@was_scoped = nil
@pending_steps = nil
Expand Down Expand Up @@ -103,12 +103,6 @@ def add_graphql_error(err)
err
end

module AlwaysAuthorized
def self.[](_key)
true
end
end

def build_arguments
query = @selections_step.query
field_name = @ast_node.name
Expand All @@ -124,10 +118,10 @@ def build_arguments

def execute_field
objects = @selections_step.objects
@results = @selections_step.results
# TODO not as good because only one error?
if @arguments.is_a?(GraphQL::RuntimeError)
@field_results = Array.new(objects.size, @arguments)
@object_is_authorized = AlwaysAuthorized
build_results
return
end
Expand All @@ -139,7 +133,6 @@ def execute_field
Schema::Validator.validate!(v, nil, ctx, @arguments)
rescue GraphQL::RuntimeError => err
@field_results = Array.new(objects.size, err)
@object_is_authorized = AlwaysAuthorized
build_results
return
end
Expand Down Expand Up @@ -170,30 +163,37 @@ def execute_field
# TODO break this backwards compat somehow?
objects = @selections_step.graphql_objects
end

if @runner.authorization && @runner.authorizes?(@field_definition, ctx)
authorized_objects = []
@object_is_authorized = objects.map { |o|
is_authed = @field_definition.authorized?(o, @arguments, ctx)
if is_authed
authorized_results = []
l = objects.size
i = 0
while i < l
o = objects[i]
if @field_definition.authorized?(o, @arguments, ctx)
authorized_results << @results[i]
authorized_objects << o
else
begin
err = GraphQL::UnauthorizedFieldError.new(object: o, type: @parent_type, context: ctx, field: @field_definition)
authorized_objects << query.schema.unauthorized_object(err)
is_authed = true
authorized_results << @results[i]
rescue GraphQL::ExecutionError => exec_err
add_graphql_error(exec_err)
end
end
is_authed
}
i += 1
end

if authorized_objects.size == 0
return
end
@results = authorized_results
else
authorized_objects = objects
@object_is_authorized = AlwaysAuthorized
end

if @parent_type.default_relay? && authorized_objects.all? { |o| o.respond_to?(:was_authorized_by_scope_items?) && o.was_authorized_by_scope_items? }
@was_scoped = true
end
Expand Down Expand Up @@ -361,18 +361,11 @@ def build_results

is_list = return_type.list?
is_non_null = return_type.non_null?
results = @selections_step.results
field_result_idx = 0
i = 0
s = results.size
s = @results.size
while i < s do
result_h = results[i]
if @object_is_authorized[i]
result = @field_results[field_result_idx]
field_result_idx += 1
else
result = nil
end
result_h = @results[i]
result = @field_results[i]
i += 1
build_graphql_result(result_h, @key, result, return_type, is_non_null, is_list, false)
end
Expand All @@ -385,18 +378,11 @@ def build_results
end
else
ctx = @selections_step.query.context
results = @selections_step.results
field_result_idx = 0
i = 0
s = results.size
s = @results.size
while i < s do
result_h = results[i]
if @object_is_authorized[i]
field_result = @field_results[field_result_idx]
field_result_idx += 1
else
field_result = nil
end
result_h = @results[i]
field_result = @field_results[i]
i += 1
finish_leaf_result(result_h, @key, field_result, return_type, ctx)
end
Expand Down Expand Up @@ -520,10 +506,14 @@ def build_graphql_result(graphql_result, key, field_result, return_type, is_nn,
build_graphql_result(list_result, i, inner_f_r, inner_type, inner_type_nn, inner_type_l, true)
i += 1
end
elsif @runner.resolves_lazies || (@runner.authorization && (@static_type.kind.object? ? @runner.authorizes?(@static_type, @selections_step.query.context) : (
(runtime_type = (@runner.runtime_type_at[graphql_result] = @runner.resolve_type(@static_type, field_result, @selections_step.query))
) && @runner.authorizes?(runtime_type, @selections_step.query.context)
)))
elsif @runner.resolves_lazies || (
@runner.authorization && (
@static_type.kind.object? ?
@runner.authorizes?(@static_type, @selections_step.query.context) :
(
(runtime_type = (@runner.runtime_type_at[graphql_result] = @runner.resolve_type(@static_type, field_result, @selections_step.query))) &&
@runner.authorizes?(runtime_type, @selections_step.query.context)
)))
obj_step = PrepareObjectStep.new(
object: field_result,
runner: @runner,
Expand Down