Add ROCm-compatible CUDA source fixes#4
Open
ZJLi2013 wants to merge 1 commit into
Open
Conversation
Remove CUDA-only includes and adjust small source incompatibilities so the extension can build under PyTorch ROCm hipify.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR applies small compatibility fixes to the existing CUDA rasterizer sources so the extension can build under PyTorch ROCm/hipify. It only modifies original source files and does not add generated HIP sources.
Changes
.cusources.smoothstephelpers using scalar component-wise calls that compile under hipcc.Reproduction
Tested On
rocm/pytorch:rocm6.4.3_ubuntu24.04_py3.12_pytorch_release_2.6.0Notes
cuda_rasterizer/*.cusource path.