Add code review guidelines for tier markers and hardware checks#2
Closed
rnetser wants to merge 1 commit into
Closed
Add code review guidelines for tier markers and hardware checks#2rnetser wants to merge 1 commit into
rnetser wants to merge 1 commit into
Conversation
- CLAUDE.md: Add tier marker review guidance (tier3 for complex/hardware-specific tests) - CodeRabbit workflow: Add hardware-related checks section (SR-IOV, GPU, DPDK) requiring collection safety verification on clusters with and without hardware
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds code review guidelines to improve review consistency and prevent common issues:
@pytest.mark.tier1/tier2/tier3) on new tests, referencing pytest.ini for available markersgpu_nodes,sriov_node,sriov_namespace, etc.) and ensure proper skip conditions are in place to prevent collection errors on clusters without specialized hardwareContext
These guidelines were informed by discussions and issues from:
Why