Skip to content

Add code review guidelines for tier markers and hardware checks#2

Closed
rnetser wants to merge 1 commit into
mainfrom
cr-instruct
Closed

Add code review guidelines for tier markers and hardware checks#2
rnetser wants to merge 1 commit into
mainfrom
cr-instruct

Conversation

@rnetser

@rnetser rnetser commented Feb 3, 2026

Copy link
Copy Markdown
Owner

Summary

This PR adds code review guidelines to improve review consistency and prevent common issues:

  • Tier marker guidance in CLAUDE.md: Added reviewer instruction to check for missing tier markers (@pytest.mark.tier1/tier2/tier3) on new tests, referencing pytest.ini for available markers
  • Hardware fixture checks in CodeRabbit workflow: Added guidance to detect hardware-specific fixtures (gpu_nodes, sriov_node, sriov_namespace, etc.) and ensure proper skip conditions are in place to prevent collection errors on clusters without specialized hardware

Context

These guidelines were informed by discussions and issues from:

Why

  • Tier markers: Ensures all new tests are properly categorized for test execution filtering, preventing unmarked tests from being missed in CI runs
  • Hardware checks: Prevents collection errors when tests use hardware-specific fixtures without proper skip conditions, which causes test suite failures on clusters lacking specialized hardware (GPU, SR-IOV, etc.)

- CLAUDE.md: Add tier marker review guidance (tier3 for complex/hardware-specific tests)
- CodeRabbit workflow: Add hardware-related checks section (SR-IOV, GPU, DPDK)
  requiring collection safety verification on clusters with and without hardware
@rnetser rnetser closed this Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant