Add TypeScript types for Standard Style configuration#4210
Open
mfazekas wants to merge 4 commits into
Open
Conversation
mfazekas
force-pushed
the
feat/standard-style-config
branch
from
eb32702 to
b10087f
Compare
…docs The doc generator now properly renders intersection types (showing the typed object members) and union types (showing the actual values instead of just "union").
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds proper TypeScript types (
StandardStyleConfig) for theconfigprop onStyleImport, providing autocomplete and type safety for all known Mapbox Standard style configuration options (light presets, themes, 3D features, labels, and color overrides). Arbitrary string keys are still accepted for forward compatibility.Test plan
yarn type:check- passes with no new errorsconfig={{ }}on a<StyleImport>componentStyleImportConfig.tsxcompiles without errors