Skip to content

Commit 3b6fcc3

Browse files
committed
Use progress notification for checkpoint restoration on accepted responses and clear progress when response preview starts
1 parent 0ea4799 commit 3b6fcc3

3 files changed

Lines changed: 18 additions & 3 deletions

File tree

apps/editor/src/commands/checkpoints-command/actions/restore-checkpoint.ts

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -545,12 +545,18 @@ export const restore_checkpoint = async (params: {
545545
? 'Successfully reverted changes.'
546546
: 'Checkpoint has been restored.'
547547

548-
if (params.options?.show_auto_closing_modal_on_success) {
548+
if (params.checkpoint.trigger == 'response-accepted') {
549+
params.panel_provider.send_message({
550+
command: 'SHOW_PROGRESS',
551+
title: message.endsWith('.') ? message.slice(0, -1) : message,
552+
cancellable: false,
553+
delay_visibility: true
554+
})
555+
} else if (params.options?.show_auto_closing_modal_on_success) {
549556
params.panel_provider.send_message({
550557
command: 'SHOW_AUTO_CLOSING_MODAL',
551558
title: message.slice(0, -1),
552-
type: 'success',
553-
non_dismissable: true
559+
type: 'success'
554560
})
555561
} else if (temp_checkpoint) {
556562
const action = await vscode.window.showInformationMessage(

apps/editor/src/views/panel/frontend/hooks/use-modal-manager.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,8 @@ export const use_modal_manager = () => {
8888
set_is_preview_ongoing_modal_visible(true)
8989
} else if (message.command == 'SHOW_RELEVANT_FILES_MODAL') {
9090
set_relevant_files_modal_data({ files: message.files })
91+
} else if (message.command == 'RESPONSE_PREVIEW_STARTED') {
92+
set_progress_state(undefined)
9193
}
9294
}
9395

apps/editor/src/views/panel/types/messages.ts

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -878,6 +878,12 @@ export interface ShowAutoClosingModalMessage extends BaseMessage {
878878
non_dismissable?: boolean
879879
}
880880

881+
export interface ShowNeverClosingModalMessage extends BaseMessage {
882+
command: 'SHOW_NEVER_CLOSING_MODAL'
883+
title: string
884+
type: 'success' | 'warning' | 'error' | 'info'
885+
}
886+
881887
export interface UpdateFileInPreviewMessage extends BaseMessage {
882888
command: 'UPDATE_FILE_IN_PREVIEW'
883889
file: FileInPreview
@@ -974,6 +980,7 @@ export type BackendMessage =
974980
| ShowApiManagerProgressMessage
975981
| HideApiManagerProgressMessage
976982
| ShowAutoClosingModalMessage
983+
| ShowNeverClosingModalMessage
977984
| UpdateFileInPreviewMessage
978985
| CollapsedStatesMessage
979986
| CheckpointsMessage

0 commit comments

Comments
 (0)