Refactor intelligent update config selection by moving it to utils and removing default button functionality

Author: robertpiosik

packages/vscode/src/commands/apply-chat-response-command/response-processor.ts

@@ -10,7 +10,7 @@ import { Diff } from './utils/clipboard-parser/extract-diff-patches'
 import { apply_git_patch } from './handlers/diff-handler'
 import { apply_file_relocations, undo_files } from './utils/file-operations'
 import { ModelProvidersManager } from '@/services/model-providers-manager'
-import { get_intelligent_update_config } from './utils/config-picker'
+import { get_intelligent_update_config } from '@/utils/intelligent-update-utils'
 import { PROVIDERS } from '@shared/constants/providers'
 import { handle_intelligent_update } from './handlers/intelligent-update-handler'
 import { check_for_truncated_fragments } from '@/utils/check-for-truncated-fragments'

packages/vscode/src/commands/apply-chat-response-command/utils/config-picker.ts

@@ -38,35 +38,8 @@ export const get_intelligent_update_config = async (
   }
 
   if (!selected_config || show_quick_pick) {
-    const set_default_button = {
-      iconPath: new vscode.ThemeIcon('star'),
-      tooltip: 'Set as default'
-    }
-
-    const unset_default_button = {
-      iconPath: new vscode.ThemeIcon('star-full'),
-      tooltip: 'Unset default'
-    }
-
     const create_items = async () => {
-      const default_config =
-        await api_providers_manager.get_default_intelligent_update_config()
-
       return intelligent_update_configs.map((config, index) => {
-        const buttons = []
-
-        const is_default =
-          default_config &&
-          default_config.provider_type == config.provider_type &&
-          default_config.provider_name == config.provider_name &&
-          default_config.model == config.model
-
-        if (is_default) {
-          buttons.push(unset_default_button)
-        } else {
-          buttons.push(set_default_button)
-        }
-
         return {
           label: config.model,
           description: `${
@@ -78,16 +51,15 @@ export const get_intelligent_update_config = async (
           }`,
           config,
           index,
-          id: get_tool_config_id(config),
-          buttons
+          id: get_tool_config_id(config)
         }
       })
     }
 
     const quick_pick = vscode.window.createQuickPick()
     const items = await create_items()
     quick_pick.items = items
-    quick_pick.title = 'Configuration'
+    quick_pick.title = 'Configurations'
     quick_pick.placeholder =
       'Select the Intelligent Update API tool configuration'
     quick_pick.matchOnDescription = true
@@ -109,24 +81,6 @@ export const get_intelligent_update_config = async (
 
     return new Promise<{ provider: any; config: ToolConfig } | undefined>(
       (resolve) => {
-        quick_pick.onDidTriggerItemButton(async (event) => {
-          const item = event.item as any
-          const button = event.button
-          const index = item.index
-
-          if (button === set_default_button) {
-            await api_providers_manager.set_default_intelligent_update_config(
-              intelligent_update_configs[index]
-            )
-            quick_pick.items = await create_items()
-          } else if (button === unset_default_button) {
-            await api_providers_manager.set_default_intelligent_update_config(
-              null as any
-            )
-            quick_pick.items = await create_items()
-          }
-        })
-
         quick_pick.onDidAccept(async () => {
           const selected = quick_pick.selectedItems[0] as any
           quick_pick.hide()

packages/vscode/src/utils/intelligent-update-utils.ts

@@ -11,53 +11,14 @@ import { Logger } from '@shared/utils/logger'
 import { parse_response } from '@/commands/apply-chat-response-command/utils/clipboard-parser'
 import { ModelProvidersManager } from '@/services/model-providers-manager'
 import { PROVIDERS } from '@shared/constants/providers'
-import { process_file } from '@/utils/intelligent-update-utils'
+import {
+  get_intelligent_update_config,
+  process_file
+} from '@/utils/intelligent-update-utils'
 import { create_safe_path } from '@/utils/path-sanitizer'
 import { dictionary } from '@shared/constants/dictionary'
 import axios from 'axios'
 
-const get_default_intelligent_update_config = async (
-  api_providers_manager: ModelProvidersManager
-): Promise<{ provider: any; config: any } | undefined> => {
-  const intelligent_update_configs =
-    await api_providers_manager.get_intelligent_update_tool_configs()
-
-  if (intelligent_update_configs.length == 0) {
-    vscode.commands.executeCommand('codeWebChat.settings')
-    vscode.window.showInformationMessage(
-      dictionary.information_message.NO_INTELLIGENT_UPDATE_CONFIGURATIONS_FOUND
-    )
-    return
-  }
-
-  const selected_config =
-    await api_providers_manager.get_default_intelligent_update_config()
-
-  if (!selected_config) {
-    vscode.commands.executeCommand('codeWebChat.settings')
-    vscode.window.showInformationMessage(
-      dictionary.information_message.NO_DEFAULT_INTELLIGENT_UPDATE_CONFIGURATION
-    )
-    return
-  }
-
-  const provider = await api_providers_manager.get_provider(
-    selected_config.provider_name
-  )
-
-  if (!provider) {
-    vscode.window.showErrorMessage(
-      dictionary.error_message.API_PROVIDER_FOR_DEFAULT_CONFIG_NOT_FOUND
-    )
-    return
-  }
-
-  return {
-    provider,
-    config: selected_config
-  }
-}
-
 export const handle_intelligent_update_file_in_preview = async (
   panel_provider: PanelProvider,
   message: IntelligentUpdateFileInPreviewMessage
@@ -131,8 +92,10 @@ export const handle_intelligent_update_file_in_preview = async (
   const api_providers_manager = new ModelProvidersManager(
     panel_provider.context
   )
-  const config_result = await get_default_intelligent_update_config(
-    api_providers_manager
+  const config_result = await get_intelligent_update_config(
+    api_providers_manager,
+    false,
+    panel_provider.context
   )
   if (!config_result) return