Update preset handling to transmit all mode-specific presets to the webview at once

Author: robertpiosik

packages/vscode/src/view/backend/view-provider.ts

@@ -394,8 +394,7 @@ export class ViewProvider implements vscode.WebviewViewProvider {
           } else if (message.command == 'GET_WEB_MODE') {
             handle_get_mode_web(this)
           } else if (message.command == 'SAVE_WEB_MODE') {
-            handle_save_mode_web(this, message.mode)
-            this.send_presets_to_webview(webview_view.webview)
+            await handle_save_mode_web(this, message.mode)
           } else if (message.command == 'GET_API_MODE') {
             handle_get_mode_api(this)
           } else if (message.command == 'SAVE_API_MODE') {
@@ -429,17 +428,32 @@ export class ViewProvider implements vscode.WebviewViewProvider {
 
   public send_presets_to_webview(_: vscode.Webview) {
     const config = vscode.workspace.getConfiguration('codeWebChat')
-    const presets_config_key = this.get_presets_config_key()
-    const web_chat_presets_config =
-      config.get<ConfigPresetFormat[]>(presets_config_key, []) || []
-
-    const presets_for_ui: Preset[] = web_chat_presets_config
-      .filter((preset_config) => CHATBOTS[preset_config.chatbot])
-      .map((preset_config) => config_preset_to_ui_format(preset_config))
-
+    const web_modes: WebMode[] = [
+      'ask',
+      'edit',
+      'code-completions',
+      'no-context'
+    ]
+    const mode_to_config_key: Record<WebMode, string> = {
+      ask: 'chatPresetsForAskAboutContext',
+      edit: 'chatPresetsForEditContext',
+      'code-completions': 'chatPresetsForCodeAtCursor',
+      'no-context': 'chatPresetsForNoContext'
+    }
+    const all_presets = Object.fromEntries(
+      web_modes.map((mode) => {
+        const presets_config_key = mode_to_config_key[mode]
+        const presets_config =
+          config.get<ConfigPresetFormat[]>(presets_config_key, []) || []
+        const presets_ui = presets_config
+          .filter((preset_config) => CHATBOTS[preset_config.chatbot])
+          .map((preset_config) => config_preset_to_ui_format(preset_config))
+        return [mode, presets_ui]
+      })
+    ) as { [T in WebMode]: Preset[] }
     this.send_message<PresetsMessage>({
       command: 'PRESETS',
-      presets: presets_for_ui
+      presets: all_presets
     })
   }
 

packages/vscode/src/view/frontend/home/Home.tsx

@@ -32,7 +32,9 @@ type Props = {
 
 export const Home: React.FC<Props> = (props) => {
   const [is_connected, set_is_connected] = useState<boolean>()
-  const [presets, set_presets] = useState<Preset[]>()
+  const [all_presets, set_all_presets] = useState<{
+    [T in WebMode]: Preset[]
+  }>()
   const [selected_presets, set_selected_presets] = useState<string[]>([])
   const [has_active_editor, set_has_active_editor] = useState<boolean>()
   const [has_active_selection, set_has_active_selection] = useState<boolean>()
@@ -60,7 +62,7 @@ export const Home: React.FC<Props> = (props) => {
           set_is_connected(message.connected)
           break
         case 'PRESETS':
-          set_presets((message as PresetsMessage).presets)
+          set_all_presets((message as PresetsMessage).presets)
           break
         case 'SELECTED_PRESETS':
           set_selected_presets(message.names)
@@ -198,8 +200,10 @@ export const Home: React.FC<Props> = (props) => {
   }
 
   const handle_presets_reorder = (reordered_presets: Preset[]) => {
-    // Update local state
-    set_presets(reordered_presets)
+    if (all_presets) {
+      // Update local state
+      set_all_presets({ ...all_presets, [current_mode]: reordered_presets })
+    }
 
     // Send message to extension to save the new order
     props.vscode.postMessage({
@@ -227,7 +231,14 @@ export const Home: React.FC<Props> = (props) => {
   }
 
   const handle_preset_edit = (name: string) => {
-    const preset = presets?.find((preset) => preset.name == name)
+    const current_presets = all_presets
+      ? all_presets[
+          props.home_view_type === HOME_VIEW_TYPES.WEB
+            ? props.web_mode
+            : props.api_mode
+        ]
+      : []
+    const preset = current_presets.find((preset) => preset.name == name)
     if (preset) props.on_preset_edit(preset)
   }
 
@@ -392,7 +403,7 @@ export const Home: React.FC<Props> = (props) => {
 
   if (
     is_connected === undefined ||
-    presets === undefined ||
+    all_presets === undefined ||
     has_active_editor === undefined ||
     has_active_selection === undefined ||
     ask_history === undefined ||
@@ -407,6 +418,13 @@ export const Home: React.FC<Props> = (props) => {
     return <></>
   }
 
+  const presets_for_current_mode =
+    all_presets[
+      props.home_view_type === HOME_VIEW_TYPES.WEB
+        ? props.web_mode
+        : props.api_mode
+    ]
+
   return (
     <HomeView
       on_show_intro={props.on_show_intro}
@@ -415,7 +433,7 @@ export const Home: React.FC<Props> = (props) => {
       on_search_click={handle_search_click}
       on_at_sign_click={handle_at_sign_click}
       is_connected={is_connected}
-      presets={presets}
+      presets={presets_for_current_mode}
       selected_presets={selected_presets}
       on_create_preset={handle_create_preset}
       on_quick_action_click={handle_quick_action_click}

packages/vscode/src/view/types/messages.ts

@@ -1,4 +1,3 @@
-import { CHATBOTS } from '@shared/constants/chatbots'
 import { EditFormat } from '@shared/types/edit-format'
 import { Preset } from '@shared/types/preset'
 import { PROVIDERS } from '@shared/constants/providers'
@@ -208,23 +207,9 @@ export interface EditFormatMessage extends BaseMessage {
   api_edit_format: EditFormat
 }
 
-export interface PresetMessageFormat {
-  name: string
-  chatbot: keyof typeof CHATBOTS
-  prompt_prefix?: string
-  prompt_suffix?: string
-  model?: string
-  temperature?: number
-  top_p?: number
-  thinking_budget?: number
-  system_instructions?: string
-  options?: string[]
-  port?: number
-}
-
 export interface PresetsMessage extends BaseMessage {
   command: 'PRESETS'
-  presets: PresetMessageFormat[]
+  presets: { [T in WebMode]: Preset[] }
 }
 
 export interface SelectedPresetsMessage extends BaseMessage {