Skip to content

Commit d3adc0d

Browse files
committed
Replace any with Provider interface across API-related commands and utilities to improve type safety
1 parent 37e8b60 commit d3adc0d

5 files changed

Lines changed: 14 additions & 10 deletions

File tree

apps/editor/src/commands/find-relevant-files-command/utils/fetch-relevant-files-from-api.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,14 @@ import { apply_reasoning_effort } from '../../../utils/apply-reasoning-effort'
99
import { build_user_content } from '../../../utils/build-user-content'
1010
import { Logger } from '@shared/utils/logger'
1111
import { FileData } from './analyze-workspace-files'
12+
import { Provider } from '../../../services/model-providers-manager'
1213
import { t } from '@/i18n'
1314

1415
export const fetch_relevant_files_from_api = async (
1516
files_data: FileData[],
1617
shrink_result: boolean,
1718
instructions: string,
18-
provider: any,
19+
provider: Provider,
1920
selected_config: any
2021
): Promise<string[] | 'cancel' | 'error_no_files' | 'error'> => {
2122
let xml_files = `<files>\n`

apps/editor/src/commands/generate-commit-message-command/utils/generate-commit-message-with-api.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,12 @@ import { display_token_count } from '@/utils/display-token-count'
66
import { Logger } from '@shared/utils/logger'
77
import { strip_wrapping_quotes } from './strip-wrapping-quotes'
88
import { CommitMessageConfig } from './get-commit-message-config'
9+
import { Provider } from '@/services/model-providers-manager'
910
import { t } from '@/i18n'
1011

1112
export const generate_commit_message_with_api = async (params: {
1213
endpoint_url: string
13-
provider: any
14+
provider: Provider
1415
config: CommitMessageConfig
1516
message: string
1617
}): Promise<string> => {

apps/editor/src/utils/apply-reasoning-effort.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
import { ToolConfig } from '@/services/model-providers-manager'
1+
import { ToolConfig, Provider } from '@/services/model-providers-manager'
22

33
export const apply_reasoning_effort = (params: {
44
body: { [key: string]: any }
5-
provider: any
5+
provider: Provider
66
reasoning_effort?: ToolConfig['reasoning_effort']
77
}) => {
88
if (params.provider.base_url == 'https://openrouter.ai/api/v1') {
@@ -15,7 +15,7 @@ export const apply_reasoning_effort = (params: {
1515
}
1616
} else if (
1717
params.provider.base_url ==
18-
'https://generativelanguage.googleapis.com/v1beta/openai'
18+
'https://generativelanguage.googleapis.com/v1beta/openai/v1'
1919
) {
2020
params.body.extra_body = {
2121
google: {

apps/editor/src/utils/intelligent-update-utils.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ import axios, { CancelToken } from 'axios'
33
import {
44
ModelProvidersManager,
55
ToolConfig,
6+
Provider,
67
get_tool_config_id
78
} from '@/services/model-providers-manager'
89
import { RECENTLY_USED_INTELLIGENT_UPDATE_CONFIG_IDS_STATE_KEY } from '../constants/state-keys'
@@ -17,7 +18,7 @@ export const get_intelligent_update_config = async (
1718
api_providers_manager: ModelProvidersManager,
1819
show_quick_pick: boolean = false,
1920
context: vscode.ExtensionContext
20-
): Promise<{ provider: any; config: ToolConfig } | undefined> => {
21+
): Promise<{ provider: Provider; config: ToolConfig } | undefined> => {
2122
const intelligent_update_configs =
2223
await api_providers_manager.get_tool_configs()
2324

@@ -132,7 +133,7 @@ export const get_intelligent_update_config = async (
132133
}
133134
}
134135

135-
return new Promise<{ provider: any; config: ToolConfig } | undefined>(
136+
return new Promise<{ provider: Provider; config: ToolConfig } | undefined>(
136137
(resolve) => {
137138
quick_pick.onDidTriggerButton((button) => {
138139
if (button.tooltip == 'Close') {
@@ -213,7 +214,7 @@ export const get_intelligent_update_config = async (
213214
export const process_file = async (params: {
214215
endpoint_url: string
215216
api_key: string
216-
provider: any
217+
provider: Provider
217218
model: string
218219
temperature?: number
219220
reasoning_effort?: string

apps/editor/src/views/panel/backend/message-handlers/handle-code-at-cursor.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import { FilesCollector } from '@/utils/files-collector'
55
import {
66
ModelProvidersManager,
77
ToolConfig,
8+
Provider,
89
get_tool_config_id
910
} from '@/services/model-providers-manager'
1011
import { Logger } from '@shared/utils/logger'
@@ -23,7 +24,7 @@ const get_code_at_cursor_config = async (
2324
context: vscode.ExtensionContext,
2425
panel_provider: PanelProvider,
2526
config_id?: string
26-
): Promise<{ provider: any; config: any } | undefined> => {
27+
): Promise<{ provider: Provider; config: ToolConfig } | undefined> => {
2728
const code_completions_configs =
2829
await api_providers_manager.get_tool_configs()
2930

@@ -155,7 +156,7 @@ const get_code_at_cursor_config = async (
155156
}
156157
}
157158

158-
return new Promise<{ provider: any; config: any } | undefined>(
159+
return new Promise<{ provider: Provider; config: ToolConfig } | undefined>(
159160
(resolve) => {
160161
quick_pick.onDidAccept(async () => {
161162
const selected = quick_pick.selectedItems[0] as any

0 commit comments

Comments
 (0)