Add interface adsorption and bulk species support#47
Merged
Conversation
…ules; implement smiles2xyz and improve water box generation
Owner
|
Please add doc under the |
b13d121 to
1e9f14d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhancement for symmetric interface modeling:
The bulk solution phase is defined within the middle 1/2 of the simulation box (from 1/4 to 3/4 of the box height).
To maintain a consistent density, the number of water molecules is adjusted based on the number of heavy atoms introduced from the bulk species.