Skip to content

Commit 7cdccbb

Browse files
committed
Add search depth for context tree instead of running in thread
1 parent 927e317 commit 7cdccbb

3 files changed

Lines changed: 9 additions & 36 deletions

File tree

robocorp-code/src/robocorp_code/inspector/java/java_inspector.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,9 +65,9 @@ def list_windows(self) -> List[JavaWindowInfoTypedDict]:
6565
return [to_window_info(window) for window in windows]
6666

6767
def collect_tree(
68-
self, window: str, locator: Optional[str] = None
68+
self, window: str, search_depth: int = 8, locator: Optional[str] = None
6969
) -> LocatorTreeInfoTypedDict:
7070
log.info(f"Collect tree from locator: {locator}")
7171

72-
tree = self._inspector.collect_tree(window, locator)
72+
tree = self._inspector.collect_tree(window, search_depth, locator)
7373
return [to_locator_info(node) for node in tree]

robocorp-code/src/robocorp_code/inspector/java/robocorp_java/_context_tree.py

Lines changed: 0 additions & 23 deletions
This file was deleted.

robocorp-code/src/robocorp_code/inspector/java/robocorp_java/_inspector.py

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,11 @@ def wrapper(self: "ElementInspector", *args, **kwargs):
1111

1212
event_pump_thread = EventPumpThread()
1313
event_pump_thread.start()
14-
jab_wrapper = event_pump_thread.get_wrapper()
15-
ret = func(self, jab_wrapper, *args, **kwargs)
16-
event_pump_thread.stop()
14+
try:
15+
jab_wrapper = event_pump_thread.get_wrapper()
16+
ret = func(self, jab_wrapper, *args, **kwargs)
17+
finally:
18+
event_pump_thread.stop()
1719
return ret
1820

1921
return wrapper
@@ -27,17 +29,11 @@ def collect_tree(
2729
self,
2830
jab_wrapper: JavaAccessBridgeWrapper,
2931
window: str,
32+
search_depth: int,
3033
locator: Optional[str] = None,
3134
) -> Union[ContextNode, List[ContextNode]]:
3235
jab_wrapper.switch_window_by_title(window)
33-
34-
from ._context_tree import ContextTreeThread
35-
36-
context_tree_thread = ContextTreeThread(jab_wrapper)
37-
context_tree_thread.start()
38-
context_tree = context_tree_thread.get_context_tree()
39-
context_tree_thread.join()
40-
36+
context_tree = ContextTree(jab_wrapper, search_depth)
4137
if locator:
4238
from ._locators import find_elements_from_tree
4339

0 commit comments

Comments
 (0)