fix(windows): raise when Select cannot find a value#1326
Merged
mikahanninen merged 3 commits intoMay 3, 2026
Conversation
RPA.Windows ignored the boolean result of the underlying UIAutomation Select call, so missing combo box values looked like successful selections. Raise ActionNotPossible on an explicit False return and lock the behavior with a focused regression test. Constraint: uiautomation reports missing selectable values with False instead of raising Rejected: Treat every falsy return as failure | preserve compatibility with implementations that succeed with None Confidence: high Scope-risk: narrow Reversibility: clean Directive: Keep the explicit False check unless upstream Select starts raising its own error Tested: python -m pytest packages/windows/tests/python/test_windows.py -q -p no:cacheprovider Not-tested: Manual selection against a real Windows combo box
|
|
… None Add a happy-path counterpart to the existing Select failure test. UIAutomation COM methods return None on success (void); the guard uses `is False` (identity) so None must not trigger ActionNotPossible. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Falsereturn from UIAutomationSelect()as a failed selectionActionNotPossiblewhen the requested combo box value is not availableCloses #1150.
Test plan
python -m pytest packages/windows/tests/python/test_windows.py -q -p no:cacheprovider