fix(security): sanitize archive extraction paths in RPA.Archive (zip slip)#1341
Open
mikahanninen wants to merge 1 commit into
Open
fix(security): sanitize archive extraction paths in RPA.Archive (zip slip)#1341mikahanninen wants to merge 1 commit into
mikahanninen wants to merge 1 commit into
Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
Wheel artifactBuilt from commit Artifact name: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RPA.Archive.Extract Archive. Both thezipfileandtarfileextraction branches calledextractall()without validating member paths, so a crafted archive with an entry like../../evil.pycould write files outside the requested destination directory._check_extraction_safety()which resolves each member's destination path and raisesValueErrorif it would escape the target directory, applied before extraction for both zip and tar archives (whole-archive and selected-membersextraction).tests/python/test_archive.py) covering rejected zip/tar traversal archives and a normal extraction still working.rpaframeworkto 32.0.2 and updates release notes.Fixes #1339, #1340.
Test plan
uv run pytest tests/python/test_archive.py -vv— 3 passed (rejects zip slip, rejects tar slip, normal extraction still works)invoke code.test-robot -r archive— 19/19 existing Robot Framework tests still pass (no regression to normal extraction behavior)pylintclean onArchive.py🤖 Generated with Claude Code