Skip to content

changes for treating color as with rgb_color instead of string #2249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
rafel-roboflow wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

changes for treating color as with rgb_color instead of string #2249

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions inference/core/workflows/execution_engine/v1/dynamic_blocks/block_assembler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,13 @@ def build_input(
return input_type, field_metadata


# Kinds whose values are serialized as strings on the wire. When one of these kinds
# is declared on the selector side of a dynamic input, `str` is auto-added to the
# accepted value types so literals like "BLACK" or "#FF0000" are accepted — mirroring
# how core blocks like text_display declare `Union[str, Selector(kind=[STRING_KIND])]`.
_STRING_LITERAL_KINDS = {"rgb_color"}


def build_input_field_type(
block_type: str,
input_name: str,
Expand All @@ -238,6 +245,11 @@ def build_input_field_type(
input_name=input_name,
input_definition=input_definition,
)
if (
_declares_string_literal_kind(input_definition)
and str not in input_type_union_elements
):
input_type_union_elements.append(str)
if not input_type_union_elements:
raise DynamicBlockError(
public_message=f"There is no definition of input type found for property: {input_name} of "
Expand All @@ -253,6 +265,13 @@ def build_input_field_type(
return input_type


def _declares_string_literal_kind(input_definition: DynamicInputDefinition) -> bool:
for kinds in input_definition.selector_data_kind.values():
if any(kind in _STRING_LITERAL_KINDS for kind in kinds):
return True
return False


def collect_python_types_for_selectors(
block_type: str,
input_name: str,
Expand Down
Loading