Do not return *_ref objects.

Benjamin Chrétien · Benjamin Chrétien · commit 7f565de4a558 · 2015-03-07T16:50:05.000+01:00
This would return references to temporary local Eigen::Ref objects.
diff --git a/include/roboptim/core/plugin/cminpack.hh b/include/roboptim/core/plugin/cminpack.hh
@@ -75,25 +75,25 @@ namespace roboptim {
       }
 
       /// Get parameter
-      argument_ref parameter ()
+      argument_t& parameter ()
       {
 	return parameter_;
       }
 
-      const_argument_ref parameter () const
+      const argument_t& parameter () const
       {
 	return parameter_;
       }
 
       /// Get value
-      const_argument_ref value () const
+      const argument_t& value () const
       {
 	(*cost_)(value_, parameter_);
 	return value_;
       }
 
       /// Get Jacobian
-      const_gradient_ref jacobianRow (size_type iRow) const
+      const gradient_t& jacobianRow (size_type iRow) const
       {
 	(*cost_).gradient (jacobianRow_, parameter_, iRow);
 	return jacobianRow_;

Original file line number	Diff line number	Diff line change
`@@ -75,25 +75,25 @@ namespace roboptim {`
`75`	`75`	`}`
`76`	`76`
`77`	`77`	`/// Get parameter`
`78`		`- argument_ref parameter ()`
	`78`	`+ argument_t& parameter ()`
`79`	`79`	`{`
`80`	`80`	`return parameter_;`
`81`	`81`	`}`
`82`	`82`
`83`		`- const_argument_ref parameter () const`
	`83`	`+ const argument_t& parameter () const`
`84`	`84`	`{`
`85`	`85`	`return parameter_;`
`86`	`86`	`}`
`87`	`87`
`88`	`88`	`/// Get value`
`89`		`- const_argument_ref value () const`
	`89`	`+ const argument_t& value () const`
`90`	`90`	`{`
`91`	`91`	`(*cost_)(value_, parameter_);`
`92`	`92`	`return value_;`
`93`	`93`	`}`
`94`	`94`
`95`	`95`	`/// Get Jacobian`
`96`		`- const_gradient_ref jacobianRow (size_type iRow) const`
	`96`	`+ const gradient_t& jacobianRow (size_type iRow) const`
`97`	`97`	`{`
`98`	`98`	`(*cost_).gradient (jacobianRow_, parameter_, iRow);`
`99`	`99`	`return jacobianRow_;`