refactor: introduce RF_VERSION constant and remove RF < 5.0 dead code

- Add module-level RF_VERSION constant to robotcode.robot.utils,
  resolved once at import time instead of repeated lru_cache lookups
- Remove dead code paths for Robot Framework < 5.0 (no longer supported),
  including the internal tidy-based formatter and obsolete version branches
- Replace all ~134 get_robot_version() call sites across 27 files with
  the RF_VERSION constant

Author: d-biehl

bundled/tool/utils/check_robot_version.py

@@ -27,6 +27,6 @@ def update_sys_path(path_to_add: str, strategy: str) -> None:
         print("Robot Framework not installed", file=sys.stderr)
         sys.exit(1)
 
-    from robotcode.robot.utils import get_robot_version
+    from robotcode.robot.utils import RF_VERSION
 
-    print(get_robot_version() >= (4, 1))
+    print(RF_VERSION >= (5, 0))

packages/debugger/src/robotcode/debugger/debugger.py

@@ -36,11 +36,13 @@
 from robot.errors import VariableError
 from robot.output import LOGGER
 from robot.running import EXECUTION_CONTEXTS, Keyword, TestCase, TestSuite
+from robot.running.model import Try
+from robot.utils import Matcher as RobotMatcher
 from robot.variables import evaluate_expression
 
 from robotcode.core.event import event
 from robotcode.core.utils.logging import LoggingDescriptor
-from robotcode.robot.utils import get_robot_version
+from robotcode.robot.utils import RF_VERSION
 
 from .dap_types import (
     Breakpoint,
@@ -72,16 +74,12 @@
 )
 from .id_manager import IdManager
 
-if get_robot_version() >= (5, 0):
-    from robot.running.model import Try
-    from robot.utils import Matcher as RobotMatcher
-
-if get_robot_version() >= (7, 0):
+if RF_VERSION >= (7, 0):
     from robot.running import UserKeyword as UserKeywordHandler
 else:
     from robot.running.userkeyword import UserKeywordHandler
 
-if get_robot_version() >= (6, 1):
+if RF_VERSION >= (6, 1):
 
     def internal_evaluate_expression(expression: str, variable_store: Any) -> Any:
         return evaluate_expression(expression, variable_store)
@@ -303,7 +301,7 @@ def __init__(self) -> None:
         self.steps: List[Any] = []
 
 
-if get_robot_version() < (7, 0):
+if RF_VERSION < (7, 0):
 
     class DebugLogger(DebugLoggerBase):
         def start_keyword(self, kw: Any) -> None:
@@ -1119,7 +1117,7 @@ def end_test(self, name: str, attributes: AttributeDict) -> None:
 
         self.remove_stackframe_entry(longname, type, source, line_no)
 
-    if get_robot_version() >= (7, 0):
+    if RF_VERSION >= (7, 0):
 
         def get_current_keyword_handler(self, name: str) -> UserKeywordHandler:
             return EXECUTION_CONTEXTS.current.namespace.get_runner(name).keyword
@@ -1252,7 +1250,7 @@ def _should_run_except(self, branch: Any, error: str) -> bool:
 
         return False
 
-    if get_robot_version() >= (7, 0):
+    if RF_VERSION >= (7, 0):
 
         def _get_step_data(self, step: Any) -> Any:
             return step
@@ -1262,31 +1260,23 @@ def _get_step_data(self, step: Any) -> Any:
         def _get_step_data(self, step: Any) -> Any:
             return step.data
 
-    if get_robot_version() < (5, 0):
-
-        def is_not_caugthed_by_except(self, message: Optional[str]) -> bool:
-            if not message:
-                return True
-            return False
-    else:
+    def is_not_caugthed_by_except(self, message: Optional[str]) -> bool:
+        if not message:
+            return True
 
-        def is_not_caugthed_by_except(self, message: Optional[str]) -> bool:
-            if not message:
-                return True
+        # TODO resolve variables in exception message
 
-            # TODO resolve variables in exception message
-
-            if self.debug_logger:
-                if self.debug_logger.steps:
-                    for branch in [
-                        self._get_step_data(f)
-                        for f in reversed(self.debug_logger.steps)
-                        if isinstance(self._get_step_data(f), Try)
-                    ]:
-                        for except_branch in branch.except_branches:
-                            if self._should_run_except(except_branch, message):
-                                return False
-            return True
+        if self.debug_logger:
+            if self.debug_logger.steps:
+                for branch in [
+                    self._get_step_data(f)
+                    for f in reversed(self.debug_logger.steps)
+                    if isinstance(self._get_step_data(f), Try)
+                ]:
+                    for except_branch in branch.except_branches:
+                        if self._should_run_except(except_branch, message):
+                            return False
+        return True
 
     def end_keyword(self, name: str, attributes: AttributeDict) -> None:
         if self.state == State.CallKeyword:
@@ -1602,7 +1592,7 @@ def _create_variable(
 
         return Variable(name=name, value=self.debug_repr.repr(value), type=repr(type(value)))
 
-    if get_robot_version() >= (7, 0):
+    if RF_VERSION >= (7, 0):
 
         def get_handler_args(self, handler: UserKeywordHandler) -> Any:
             return handler.args
@@ -1764,7 +1754,7 @@ def _get_variables_named(
     SPLIT_LINE: ClassVar = re.compile(r"(?= {2,}| ?\t)\s*")
     CURRDIR: ClassVar = re.compile(r"(?i)\$\{CURDIR\}")
 
-    if get_robot_version() >= (7, 0):
+    if RF_VERSION >= (7, 0):
 
         def _run_keyword(self, kw: Keyword, context: Any) -> Any:
             return kw.run(context.steps[-1][1], context)
@@ -1774,7 +1764,7 @@ def _run_keyword(self, kw: Keyword, context: Any) -> Any:
         def _run_keyword(self, kw: Keyword, context: Any) -> Any:
             return kw.run(context)
 
-    if get_robot_version() >= (7, 2):
+    if RF_VERSION >= (7, 2):
 
         @staticmethod
         def check_message_is_logged(listener: Any, msg: Any) -> bool:
@@ -1963,7 +1953,7 @@ def run_kw() -> Any:
             result = None
 
             if len(test.body):
-                if get_robot_version() >= (7, 3):
+                if RF_VERSION >= (7, 3):
                     result = self._execute_keywords_with_delayed_logging_v73(test.body, evaluate_context)
                 else:
                     result = self._execute_keywords_with_delayed_logging_legacy(test.body, evaluate_context)
@@ -2003,7 +1993,7 @@ def _execute_keywords_with_delayed_logging_legacy(self, keywords: Any, evaluate_
                     result = e
                     break
                 finally:
-                    if get_robot_version() <= (7, 2):
+                    if RF_VERSION <= (7, 2):
                         self._process_delayed_log_messages()
         return result
 
@@ -2161,7 +2151,7 @@ def set_exception_breakpoints(
 
         return result or None
 
-    if get_robot_version() >= (7, 0):
+    if RF_VERSION >= (7, 0):
 
         def _get_keywords_from_lib(self, lib: Any) -> Any:
             return lib.keywords

packages/debugger/src/robotcode/debugger/launcher/server.py

@@ -11,7 +11,7 @@
 from robotcode.core.utils.logging import LoggingDescriptor
 from robotcode.jsonrpc2.protocol import rpc_method
 from robotcode.jsonrpc2.server import JsonRPCServer
-from robotcode.robot.utils import get_robot_version
+from robotcode.robot.utils import RF_VERSION
 
 from ..cli import DEBUGGER_DEFAULT_PORT, DEBUGPY_DEFAULT_PORT
 from ..dap_types import (
@@ -194,7 +194,7 @@ async def _launch(
 
         run_args = []
 
-        if get_robot_version() >= (6, 0) and languages:
+        if RF_VERSION >= (6, 0) and languages:
             for lang in languages:
                 run_args += ["--language", lang]
 

packages/language_server/src/robotcode/language_server/robotframework/parts/code_action_refactor.py

@@ -27,7 +27,6 @@
 from robotcode.core.utils.inspect import iter_methods
 from robotcode.core.utils.logging import LoggingDescriptor
 from robotcode.robot.diagnostics.model_helper import ModelHelper
-from robotcode.robot.utils import get_robot_version
 from robotcode.robot.utils.ast import (
     get_node_at_position,
     get_nodes_at_position,
@@ -152,36 +151,31 @@ def resolve(self, sender: Any, code_action: CodeAction) -> Optional[CodeAction]:
 
     def get_valid_nodes_in_range(self, model: ast.AST, range: Range, also_return: bool = False) -> List[ast.AST]:
         from robot.parsing.lexer.tokens import Token as RobotToken
-        from robot.parsing.model.blocks import Block, Keyword, TestCase
+        from robot.parsing.model.blocks import Block, Keyword, TestCase, Try
         from robot.parsing.model.statements import (
+            Break,
             Comment,
+            Continue,
             Documentation,
             ElseHeader,
             ElseIfHeader,
             EmptyLine,
             End,
+            ExceptHeader,
+            FinallyHeader,
             Fixture,
             ForHeader,
             IfHeader,
             KeywordName,
             MultiValue,
+            ReturnStatement,
             SingleValue,
             TemplateArguments,
             TestCaseName,
+            TryHeader,
+            WhileHeader,
         )
 
-        if get_robot_version() >= (5, 0, 0):
-            from robot.parsing.model.blocks import Try
-            from robot.parsing.model.statements import (
-                Break,
-                Continue,
-                ExceptHeader,
-                FinallyHeader,
-                ReturnStatement,
-                TryHeader,
-                WhileHeader,
-            )
-
         if not isinstance(model, (Keyword, TestCase)):
             return []
 
@@ -205,7 +199,7 @@ def get_valid_nodes_in_range(self, model: ast.AST, range: Range, also_return: bo
                         KeywordName,
                         TemplateArguments,
                     ),
-                ) or (also_return and get_robot_version() >= (5, 0, 0) and isinstance(node, ReturnStatement)):
+                ) or (also_return and isinstance(node, ReturnStatement)):
                     return []
 
                 result.append(node)
@@ -241,11 +235,11 @@ def get_valid_nodes_in_range(self, model: ast.AST, range: Range, also_return: bo
             n
             for n in result
             if isinstance(n, (IfHeader, ElseIfHeader, ElseHeader, ForHeader, End))
-            or (get_robot_version() >= (5, 0) and isinstance(n, (WhileHeader, TryHeader, ExceptHeader, FinallyHeader)))
+            or isinstance(n, (WhileHeader, TryHeader, ExceptHeader, FinallyHeader))
         ):
             return []
 
-        if get_robot_version() >= (5, 0, 0) and any(
+        if any(
             n
             for n in result
             if isinstance(n, (Continue, Break))