fix(robot): fix ${CURDIR} replacement in variable values and unify handling

Extract replace_curdir_in_variable_values() helper into utils/variables.py
to deduplicate the ${CURDIR} substitution logic from _MyResourceBuilder and
NamespaceAnalyzer. Fixes incorrect double-backslash escaping in
_MyResourceBuilder that caused ${CURDIR} resolution to fail on Windows.

Closes #589

Author: d-biehl

packages/robot/src/robotcode/robot/diagnostics/library_doc.py

@@ -79,7 +79,7 @@
 from ..utils.markdownformatter import MarkDownFormatter
 from ..utils.match import normalize, normalize_namespace
 from ..utils.robot_patching import patch_variable_not_found
-from ..utils.variables import contains_variable, search_variable
+from ..utils.variables import contains_variable, replace_curdir_in_variable_values, search_variable
 from .entities import (
     ArgumentDefinition,
     Import,
@@ -3199,13 +3199,7 @@ def visit_Variable(self, node: Statement) -> None:  # noqa: N802
 
             values = node.get_values(Token.ARGUMENT)
             has_value = bool(values)
-            value = tuple(
-                s.replace(
-                    "${CURDIR}",
-                    str(Path(self.source).parent).replace("\\\\", "\\\\\\\\"),
-                )
-                for s in values
-            )
+            value = replace_curdir_in_variable_values(values, self.source)
 
             stripped_name_token = strip_variable_token(name_token, matcher=matcher, parse_type=True)
 

packages/robot/src/robotcode/robot/diagnostics/namespace_analyzer.py

@@ -7,7 +7,6 @@
 from concurrent.futures import CancelledError
 from dataclasses import dataclass
 from io import StringIO
-from pathlib import Path
 from tokenize import TokenError, generate_tokens
 from typing import Any, Callable, Dict, Iterator, List, Optional, Set, Tuple, Union, cast
 
@@ -63,6 +62,7 @@
     InvalidVariableError,
     VariableMatcher,
     contains_variable,
+    replace_curdir_in_variable_values,
     search_variable,
     split_from_equals,
 )
@@ -283,13 +283,7 @@ def _visit_Variable(self, node: Variable) -> None:  # noqa: N802
 
             values = node.get_values(Token.ARGUMENT)
             has_value = bool(values)
-            value = tuple(
-                s.replace(
-                    "${CURDIR}",
-                    str(Path(self._source).parent).replace("\\", "\\\\"),
-                )
-                for s in values
-            )
+            value = replace_curdir_in_variable_values(values, self._source)
 
             var_def = VariableDefinition(
                 name=name,

packages/robot/src/robotcode/robot/utils/variables.py

@@ -1,5 +1,6 @@
 import functools
-from typing import Any, Optional, Tuple, cast
+from pathlib import Path
+from typing import Any, Optional, Sequence, Tuple, cast
 
 from robot.utils.escaping import split_from_equals as robot_split_from_equals
 from robot.variables.search import contains_variable as robot_contains_variable
@@ -225,3 +226,9 @@ def search_variable(
 @functools.lru_cache(maxsize=1024)
 def split_from_equals(string: str) -> Tuple[str, Optional[str]]:
     return cast(Tuple[str, Optional[str]], robot_split_from_equals(string))
+
+
+def replace_curdir_in_variable_values(values: Sequence[str], source: str) -> Tuple[str, ...]:
+    """Replace ${CURDIR} in variable values with the escaped parent directory of source."""
+    curdir = str(Path(source).parent).replace("\\", "\\\\")
+    return tuple(s.replace("${CURDIR}", curdir) for s in values)