fix(robotlangserver): remove possible deadlock in completion

Author: d-biehl

robotcode/language_server/common/parts/completion.py

@@ -128,6 +128,7 @@ async def _text_document_completion(
         return None
 
     @rpc_method(name="completionItem/resolve", param_type=CompletionItem)
+    @threaded()
     async def _completion_item_resolve(
         self,
         params: CompletionItem,

robotcode/language_server/common/parts/formatting.py

@@ -54,6 +54,7 @@ def extend_capabilities(self, capabilities: ServerCapabilities) -> None:
             capabilities.document_range_formatting_provider = DocumentRangeFormattingOptions(work_done_progress=True)
 
     @rpc_method(name="textDocument/formatting", param_type=DocumentFormattingParams)
+    @threaded()
     async def _text_document_formatting(
         self,
         params: DocumentFormattingParams,

robotcode/language_server/common/parts/rename.py

@@ -4,7 +4,7 @@
 from typing import TYPE_CHECKING, Any, List, Optional
 
 from ....jsonrpc2.protocol import JsonRPCErrorException, rpc_method
-from ....utils.async_tools import async_tasking_event
+from ....utils.async_tools import async_tasking_event, threaded
 from ....utils.logging import LoggingDescriptor
 from ..decorators import language_id_filter
 from ..has_extend_capabilities import HasExtendCapabilities
@@ -57,6 +57,7 @@ async def collect_prepare(
         ...
 
     @rpc_method(name="textDocument/rename", param_type=RenameParams)
+    @threaded()
     async def _text_document_rename(
         self,
         text_document: TextDocumentIdentifier,
@@ -105,6 +106,7 @@ async def _text_document_rename(
         return result
 
     @rpc_method(name="textDocument/prepareRename", param_type=PrepareRenameParams)
+    @threaded()
     async def _text_document_prepare_rename(
         self,
         text_document: TextDocumentIdentifier,

robotcode/utils/async_tools.py

@@ -425,6 +425,7 @@ def __init__(self) -> None:
         self._waiters: Optional[Deque[asyncio.Future[Any]]] = None
         self._locked = False
         self._lock = threading.RLock()
+        self._locker: Optional[asyncio.Task[Any]] = None
 
     async def __aenter__(self) -> None:
         await self.acquire()
@@ -439,7 +440,7 @@ def __repr__(self) -> str:
         extra = "locked" if self._locked else "unlocked"
         if self._waiters:
             extra = f"{extra}, waiters:{len(self._waiters)}"
-        return f"<{res[1:-1]} [{extra}]>"
+        return f"<{res[1:-1]} [{extra}]> {self._locker}"
 
     @property
     def locked(self) -> bool:
@@ -449,6 +450,7 @@ async def acquire(self) -> bool:
         with self._lock:
             if not self._locked and (self._waiters is None or all(w.cancelled() for w in self._waiters)):
                 self._locked = True
+                self._locker = asyncio.current_task()
                 return True
 
             if self._waiters is None:
@@ -461,7 +463,7 @@ async def acquire(self) -> bool:
             try:
 
                 def aaa(fut: asyncio.Future[Any]) -> None:
-                    # warnings.warn(f"Lock takes to long {threading.current_thread()}\n{s}, try to cancel...")
+                    warnings.warn(f"Lock {self} takes to long {threading.current_thread()}\n, try to cancel...")
                     fut.cancel()
 
                 # h = fut.get_loop().call_later(120, aaa, "".join(traceback.format_stack()))
@@ -481,6 +483,7 @@ def aaa(fut: asyncio.Future[Any]) -> None:
 
         with self._lock:
             self._locked = True
+            self._locker = asyncio.current_task()
 
         return True
 
@@ -489,6 +492,7 @@ def release(self) -> None:
             wake_up = False
             if self._locked:
                 self._locked = False
+                self._locker = None
                 wake_up = True
 
         if wake_up: