feat(robot): track tag and metadata references in namespace analysis

Add structured reference tracking for tags and metadata during analysis.
Tags are split into keyword_tag_references and testcase_tag_references
to reflect their different semantics in Robot Framework (keyword visibility
vs test selection/reporting). Metadata references track settings-level
metadata entries by key. All reference keys are normalized for consistent
lookups. Remove unused TagDefinition class.

Author: d-biehl

packages/robot/src/robotcode/robot/diagnostics/entities.py

@@ -372,21 +372,3 @@ def __hash__(self) -> int:
                 self.name,
             )
         )
-
-
-@dataclass(slots=True)
-class TagDefinition(SourceEntity):
-    name: str
-
-    def __hash__(self) -> int:
-        return hash(
-            (
-                type(self),
-                self.line_no,
-                self.col_offset,
-                self.end_line_no,
-                self.end_col_offset,
-                self.source,
-                self.name,
-            )
-        )

packages/robot/src/robotcode/robot/diagnostics/namespace.py

@@ -38,7 +38,6 @@
     LibraryImport,
     ResourceEntry,
     ResourceImport,
-    TagDefinition,
     TestCaseDefinition,
     VariableDefinition,
     VariablesEntry,
@@ -116,7 +115,9 @@ def __init__(
         local_variable_assignments: Dict[VariableDefinition, Set[Range]],
         namespace_references: Dict[LibraryEntry, Set[Location]],
         test_case_definitions: List[TestCaseDefinition],
-        tag_definitions: List[TagDefinition],
+        keyword_tag_references: Dict[str, Set[Location]],
+        testcase_tag_references: Dict[str, Set[Location]],
+        metadata_references: Dict[str, Set[Location]],
         scope_tree: ScopeTree,
         finder: KeywordFinder,
         sentinel: object,
@@ -140,7 +141,9 @@ def __init__(
         self._local_variable_assignments = local_variable_assignments
         self._namespace_references = namespace_references
         self._test_case_definitions = test_case_definitions
-        self._tag_definitions = tag_definitions
+        self._keyword_tag_references = keyword_tag_references
+        self._testcase_tag_references = testcase_tag_references
+        self._metadata_references = metadata_references
         self._scope_tree = scope_tree
         self._finder: KeywordFinder = finder
         self._sentinel = sentinel  # prevent GC — ref-counted by imports_manager
@@ -189,6 +192,18 @@ def local_variable_assignments(self) -> Dict[VariableDefinition, Set[Range]]:
     def namespace_references(self) -> Dict[LibraryEntry, Set[Location]]:
         return self._namespace_references
 
+    @property
+    def keyword_tag_references(self) -> Dict[str, Set[Location]]:
+        return self._keyword_tag_references
+
+    @property
+    def testcase_tag_references(self) -> Dict[str, Set[Location]]:
+        return self._testcase_tag_references
+
+    @property
+    def metadata_references(self) -> Dict[str, Set[Location]]:
+        return self._metadata_references
+
     @property
     def import_entries(self) -> Dict[Import, LibraryEntry]:
         return self._import_entries
@@ -494,7 +509,9 @@ def build(self) -> Namespace:
                 local_variable_assignments=analyzer_result.local_variable_assignments,
                 namespace_references=analyzer_result.namespace_references,
                 test_case_definitions=analyzer_result.test_case_definitions,
-                tag_definitions=analyzer_result.tag_definitions,
+                keyword_tag_references=analyzer_result.keyword_tag_references,
+                testcase_tag_references=analyzer_result.testcase_tag_references,
+                metadata_references=analyzer_result.metadata_references,
                 scope_tree=analyzer_result.scope_tree,
                 finder=finder,
                 sentinel=sentinel,

packages/robot/src/robotcode/robot/diagnostics/namespace_analyzer.py

@@ -56,6 +56,7 @@
     strip_variable_token,
     tokenize_variables,
 )
+from ..utils.match import normalize
 from ..utils.stubs import Languages
 from ..utils.variables import (
     BUILTIN_VARIABLES,
@@ -74,7 +75,6 @@
     GlobalVariableDefinition,
     LibraryEntry,
     LocalVariableDefinition,
-    TagDefinition,
     TestCaseDefinition,
     TestVariableDefinition,
     VariableDefinition,
@@ -106,11 +106,11 @@ class AnalyzerResult:
     local_variable_assignments: Dict[VariableDefinition, Set[Range]]
     namespace_references: Dict[LibraryEntry, Set[Location]]
     test_case_definitions: List[TestCaseDefinition]
-    tag_definitions: List[TagDefinition]
+    keyword_tag_references: Dict[str, Set[Location]]
+    testcase_tag_references: Dict[str, Set[Location]]
+    metadata_references: Dict[str, Set[Location]]
     scope_tree: ScopeTree = None  # type: ignore[assignment]  # set by run()
 
-    # TODO Tag references
-
 
 _builtin_variables: Optional[List[VariableDefinition]] = None
 
@@ -150,7 +150,9 @@ def __init__(
         self._local_variable_assignments: Dict[VariableDefinition, Set[Range]] = defaultdict(set)
         self._namespace_references: Dict[LibraryEntry, Set[Location]] = defaultdict(set)
         self._test_case_definitions: List[TestCaseDefinition] = []
-        self._tag_definitions: List[TagDefinition] = []
+        self._keyword_tag_references: Dict[str, Set[Location]] = defaultdict(set)
+        self._testcase_tag_references: Dict[str, Set[Location]] = defaultdict(set)
+        self._metadata_references: Dict[str, Set[Location]] = defaultdict(set)
 
         # Phase 1+2 results (set by resolve())
         self._library_doc: ResourceDoc = None  # type: ignore[assignment]  # set by resolve()
@@ -246,7 +248,9 @@ def run(self, finder: KeywordFinder) -> AnalyzerResult:
             self._local_variable_assignments,
             self._namespace_references,
             self._test_case_definitions,
-            self._tag_definitions,
+            self._keyword_tag_references,
+            self._testcase_tag_references,
+            self._metadata_references,
             self._scope_builder.build(self._variable_scope),
         )
 
@@ -1595,11 +1599,18 @@ def visit_TemplateArguments(self, node: TemplateArguments) -> None:  # noqa: N80
 
         self.generic_visit(node)
 
+    def _collect_tag_references(self, node: Statement, refs: Dict[str, Set[Location]]) -> None:
+        for token in node.get_tokens(Token.ARGUMENT):
+            if token.value:
+                refs[normalize(token.value)].add(Location(self._document_uri, range_from_token(token)))
+
     def visit_DefaultTags(self, node: Statement) -> None:  # noqa: N802
         self._analyze_statement_variables(node, DiagnosticSeverity.HINT)
+        self._collect_tag_references(node, self._testcase_tag_references)
 
     def visit_ForceTags(self, node: Statement) -> None:  # noqa: N802
         self._analyze_statement_variables(node, DiagnosticSeverity.HINT)
+        self._collect_tag_references(node, self._testcase_tag_references)
 
         if get_robot_version() >= (6, 0):
             tag = node.get_token(Token.FORCE_TAGS)
@@ -1614,6 +1625,7 @@ def visit_ForceTags(self, node: Statement) -> None:  # noqa: N802
 
     def visit_TestTags(self, node: Statement) -> None:  # noqa: N802
         self._analyze_statement_variables(node, DiagnosticSeverity.HINT)
+        self._collect_tag_references(node, self._testcase_tag_references)
 
         if get_robot_version() >= (6, 0):
             tag = node.get_token(Token.FORCE_TAGS)
@@ -1629,9 +1641,18 @@ def visit_TestTags(self, node: Statement) -> None:  # noqa: N802
     def visit_Arguments(self, node: Statement) -> None:  # noqa: N802
         pass
 
+    def visit_KeywordTags(self, node: Statement) -> None:  # noqa: N802
+        self._visit_settings_statement(node, DiagnosticSeverity.HINT)
+        self._collect_tag_references(node, self._keyword_tag_references)
+
     def visit_DocumentationOrMetadata(self, node: Statement) -> None:  # noqa: N802
         self._visit_settings_statement(node, DiagnosticSeverity.HINT)
 
+        if hasattr(node, "name") and node.name:
+            name_token = node.get_token(Token.NAME)
+            if name_token is not None:
+                self._metadata_references[node.name].add(Location(self._document_uri, range_from_token(name_token)))
+
     def visit_Timeout(self, node: Statement) -> None:  # noqa: N802
         self._visit_block_settings_statement(node)
 
@@ -1643,6 +1664,10 @@ def visit_MultiValue(self, node: Statement) -> None:  # noqa: N802
 
     def visit_Tags(self, node: Statement) -> None:  # noqa: N802
         self._visit_settings_statement(node, DiagnosticSeverity.HINT)
+        if any(isinstance(n, Keyword) for n in self._node_stack):
+            self._collect_tag_references(node, self._keyword_tag_references)
+        else:
+            self._collect_tag_references(node, self._testcase_tag_references)
 
         if (6, 0) < get_robot_version() < (7, 0):
             for tag in node.get_tokens(Token.ARGUMENT):