fix(repl): resolve relative import paths against the working directory

Imports such as `Import Resource    foo/my.resource` typed at the REPL
prompt now resolve relative to the REPL's working directory, just like
the same import does in a `.robot` file. Previously such imports only
worked when the path was absolute, prefixed with `${CURDIR}/`, or
reachable via the module search path.

This matches Robot Framework's own resolution since RF 7.4. The REPL
docs also note that on RF < 7.4 bare relative paths still fail (RF
itself doesn't resolve them that way on those versions); use
`${CURDIR}/...` or put the directory on the module search path
instead.

Author: d-biehl

docs/03_reference/repl.md

@@ -336,6 +336,8 @@ robotcode repl -P ./libs -P ./vendor/python-libs
 
 `-P` accepts the same `PATH` strings as `robot --pythonpath`.
 
+> **Heads-up for Robot Framework < 7.4.** Bare relative paths in the BuiltIn import keywords `Import Resource` / `Import Library` / `Import Variables` (e.g. `Import Resource    foo/my.resource`) only resolve against the directory of the importing file starting with RF 7.4. On older RF versions these keywords look the path up via the module search path only, so a bare relative form will fail with `Resource file '…' does not exist.` On those versions, either prefix the path with `${CURDIR}/` (e.g. `Import Resource    ${CURDIR}/foo/my.resource`) or put the directory on the module search path. On RF 7.4+ the bare form just works.
+
 ## Pre-seeding variables
 
 Variables can be set up before the prompt opens:

packages/repl/src/robotcode/repl/base_interpreter.py

@@ -1,6 +1,7 @@
 import abc
 import signal
 from datetime import datetime
+from io import StringIO
 from pathlib import Path
 from typing import TYPE_CHECKING, Any, Iterator, List, Optional, Tuple, Union, cast
 
@@ -12,7 +13,6 @@
 from robot.running.context import EXECUTION_CONTEXTS
 from robot.running.signalhandler import STOP_SIGNAL_MONITOR, _StopSignalMonitor
 
-from robotcode.core.utils.path import normalized_path
 from robotcode.robot.utils import RF_VERSION
 from robotcode.robot.utils.ast import iter_nodes
 
@@ -137,6 +137,13 @@ def __init__(self) -> None:
         self.last_result: Any = None
         self.indent = 0
         self.source: Optional[Path] = None
+        self._curdir: Optional[Path] = None
+
+    @property
+    def curdir(self) -> Path:
+        if self._curdir is None:
+            self._curdir = self.source.parent if self.source is not None else Path.cwd()
+        return self._curdir
 
     def check_for_errors(self, node: Any) -> List[str]:
         if hasattr(node, "tokens"):
@@ -158,9 +165,11 @@ def get_test_body_from_string(self, command: str) -> Tuple[TestCase, List[str]]:
             + ("\n  ".join(command.split("\n")) if "\n" in command else command)
         ) + "\n"
 
-        curdir = normalized_path(self.source).parent if self.source is not None else Path.cwd()
+        with StringIO(suite_str) as source:
+            model = get_model(source, curdir=str(self.curdir).replace("\\", "\\\\"))
+
+        model.source = self.source
 
-        model = get_model(suite_str, curdir=str(curdir).replace("\\", "\\\\"))
         suite: TestSuite = TestSuite.from_model(model)
 
         errors: List[str] = []

packages/repl/src/robotcode/repl/run.py

@@ -76,6 +76,9 @@ def run_repl(
 
     root_folder, _profile, cmd_options = handle_robot_options(app, (*robot_options_and_args, *(str(f) for f in files)))
 
+    if source is None:
+        source = Path.cwd() / "__repl_internal__.robot"
+
     with app.chdir(root_folder) as orig_folder:
         try:
             curdir = normalized_path(source).parent if source is not None else Path.cwd()
@@ -88,7 +91,7 @@ def run_repl(
                 orig_folder=orig_folder,
             ).parse_arguments((*cmd_options, *robot_options_and_args))
 
-            interpreter.source = source
+            interpreter.source = normalized_path(source) if source is not None else None
 
             settings = RobotSettings(
                 options,
@@ -113,6 +116,7 @@ def run_repl(
 
             with io.StringIO(REPL_SUITE) as suite_io:
                 model = get_model(suite_io, curdir=str(curdir).replace("\\", "\\\\"))
+                model.source = source
 
                 suite = TestSuite.from_model(model)
                 suite.configure(**settings.suite_config)