fix(analysis): respect diagnosticMode for workspace files

Diagnostics for closed workspace files could appear (or be suppressed)
inconsistently in openFilesOnly mode, depending on which file the
workspace diagnostics loop happened to iterate last.

Also clarify the diagnosticMode description so it no longer implies
that background analysis is restricted -- the setting only controls
which files diagnostics are reported for.

Co-authored-by: Petri Huovinen <petri.huovinen@nokia.com>

Author: d-biehl

package.json

@@ -1128,8 +1128,8 @@
             ],
             "default": "openFilesOnly",
             "enumDescriptions": [
-              "Analyzes and reports problems only on open files.",
-              "Analyzes and reports problems on all files in the workspace."
+              "Reports problems only on open files.",
+              "Reports problems on all files in the workspace."
             ],
             "description": "Analysis mode for diagnostics.",
             "scope": "resource"

packages/language_server/src/robotcode/language_server/common/parts/diagnostics.py

@@ -436,7 +436,7 @@ def run_workspace_diagnostics(self) -> None:
                 documents_to_collect = [
                     doc
                     for doc in documents
-                    if doc.opened_in_editor or self.get_diagnostics_mode(document.uri) == DiagnosticsMode.WORKSPACE
+                    if doc.opened_in_editor or self.get_diagnostics_mode(doc.uri) == DiagnosticsMode.WORKSPACE
                 ]
 
                 with self._logger.measure_time(