fix(runner): keep relSource in results JSON regardless of --full-paths

Aligns `results` with `discover`, which always carries both `source`
(absolute) and `relSource` in its JSON output. Two changes:

- `_make_test_item` / `_make_diff_change` / `LogTest` stop conditionally
  setting `rel_source=None` when `--full-paths` is on. The flag is now
  purely a TEXT-rendering hint.
- `_rel_to_cwd` falls back to the original path (instead of `None`)
  when the source isn't anchored under cwd, mirroring
  `discover.get_rel_source`. Consumers like the VS Code extension can
  now rely on `relSource` being present whenever `source` is.

`_make_diff_change` and `_make_test_item` no longer take `full_paths`,
since the parameter became unused after the change. Call sites updated.

Plus acceptance tests covering the harmonised behaviour on `summary`,
`show`, `log` and `diff`, and a TEXT-only `--full-paths` test on
`discover tags` (the last subcommand without coverage).

Author: d-biehl

packages/runner/src/robotcode/runner/cli/results/results.py

@@ -264,11 +264,7 @@ def summary(
             )
         match = make_search_matcher(search_substring, search_regex)
         counts = _collect_counts(execution.suite, status_filters, match)
-        failures = (
-            _collect_failures(execution.suite, status_filters, full_paths=full_paths, match=match)
-            if show_failures
-            else None
-        )
+        failures = _collect_failures(execution.suite, status_filters, match=match) if show_failures else None
         exec_msg_counts = _count_execution_messages(getattr(execution, "errors", None))
         msg_counts = _count_all_messages(execution)
 
@@ -419,7 +415,7 @@ def show(
         wanted = _normalise_statuses(status_filters)
         match = make_search_matcher(search_substring, search_regex)
         all_items = [
-            _make_test_item(t, message_chars=message_chars, full_paths=full_paths)
+            _make_test_item(t, message_chars=message_chars)
             for t in _iter_all_tests(execution.suite)
             if (not wanted or t.status in wanted) and (match is None or _raw_test_search_matches(t, match))
         ]
@@ -635,7 +631,7 @@ def log(
                     body=body,
                     artifacts=artefacts or None,
                     source=src_str,
-                    rel_source=None if full_paths else _rel_to_cwd(src_str),
+                    rel_source=_rel_to_cwd(src_str),
                     lineno=getattr(test, "lineno", None) or None,
                     elapsed_seconds=_elapsed_seconds(test),
                     start_time=_iso(_start_time(test)),
@@ -1008,11 +1004,11 @@ def _eligible(t: Any) -> bool:
         for name, cur in current_tests.items():
             base = baseline_tests.get(name)
             if base is None:
-                added.append(_make_diff_change(name, None, cur, message_chars=message_chars, full_paths=full_paths))
+                added.append(_make_diff_change(name, None, cur, message_chars=message_chars))
                 continue
             if base.status == cur.status:
                 continue
-            change = _make_diff_change(name, base, cur, message_chars=message_chars, full_paths=full_paths)
+            change = _make_diff_change(name, base, cur, message_chars=message_chars)
             if base.status == "PASS" and cur.status in ("FAIL", "ERROR"):
                 new_failures.append(change)
             elif base.status in ("FAIL", "ERROR", "SKIP") and cur.status == "PASS":
@@ -1022,7 +1018,7 @@ def _eligible(t: Any) -> bool:
 
         for name, base in baseline_tests.items():
             if name not in current_tests:
-                removed.append(_make_diff_change(name, base, None, message_chars=message_chars, full_paths=full_paths))
+                removed.append(_make_diff_change(name, base, None, message_chars=message_chars))
 
         selected = {c.lower() for c in only_categories} if only_categories else None
 
@@ -1072,7 +1068,6 @@ def _make_diff_change(
     current_test: Any,
     *,
     message_chars: int,
-    full_paths: bool,
 ) -> DiffChange:
     """Build a DiffChange capturing baseline/current status, message, and source."""
     src_test = current_test if current_test is not None else baseline_test
@@ -1089,7 +1084,7 @@ def _make_diff_change(
         if current_test is not None
         else None,
         source=src_str,
-        rel_source=None if full_paths else _rel_to_cwd(src_str),
+        rel_source=_rel_to_cwd(src_str),
         lineno=getattr(src_test, "lineno", None) or None,
     )
 
@@ -1471,23 +1466,29 @@ def _sort_items(items: List[TestResultItem], field: Optional[str], reverse: bool
 
 
 def _rel_to_cwd(p: Optional[str]) -> Optional[str]:
+    """Return the source path as relative-to-cwd if possible, else the
+    original path. Mirrors `discover.get_rel_source`: `rel_source` in
+    JSON is always non-None when `source` is set, falling back to the
+    absolute path when the source isn't anchored under cwd. The schema
+    invariant matters for consumers like the VS Code extension which
+    rely on `relSource` being present.
+    """
     if p is None:
         return None
     try:
         return str(Path(p).relative_to(Path.cwd()).as_posix())
     except ValueError:
-        return None
+        return p
 
 
 def _make_file_info(path: Path) -> ResultFileInfo:
-    rel = _rel_to_cwd(str(path))
     return ResultFileInfo(
         source=str(path),
-        rel_source=rel if rel and rel != str(path) else None,
+        rel_source=_rel_to_cwd(str(path)),
     )
 
 
-def _make_test_item(test: Any, *, message_chars: int, full_paths: bool) -> TestResultItem:
+def _make_test_item(test: Any, *, message_chars: int) -> TestResultItem:
     msg = test.message or ""
     first_line = msg.splitlines()[0] if msg else ""
     truncated_msg = first_line
@@ -1513,7 +1514,7 @@ def _make_test_item(test: Any, *, message_chars: int, full_paths: bool) -> TestR
         elapsed_seconds=_elapsed_seconds(test),
         start_time=_iso(_start_time(test)),
         source=src_str,
-        rel_source=None if full_paths else rel_src,
+        rel_source=rel_src,
         lineno=getattr(test, "lineno", None) or None,
     )
 
@@ -1522,7 +1523,6 @@ def _collect_failures(
     suite: Any,
     status_filters: Tuple[str, ...],
     *,
-    full_paths: bool = False,
     match: Optional["SearchMatcher"] = None,
 ) -> List[TestResultItem]:
     """Return all failed tests (post-tree-filter, after status filter) with msgs."""
@@ -1535,7 +1535,7 @@ def _collect_failures(
             continue
         if match is not None and not _raw_test_search_matches(t, match):
             continue
-        out.append(_make_test_item(t, message_chars=0, full_paths=full_paths))
+        out.append(_make_test_item(t, message_chars=0))
     return out
 
 

tests/robotcode/runner/cli/discover/test_tags.py

@@ -68,3 +68,14 @@ def test_tags_dict_values_are_testitems(json_discover: JsonRunner, tagged_suite:
             assert "type" in item
             assert "longname" in item
             assert "source" in item
+
+
+def test_tags_full_paths_text_uses_absolute(robotcode_cli: CliRunner, tagged_suite: Path) -> None:
+    """`--full-paths --tests` in TEXT mode prints the absolute child path."""
+    abs_str = str(tagged_suite.resolve())
+    full = robotcode_cli(
+        ["--root", str(tagged_suite.parent), "discover", "tags", "--tests", "--full-paths", str(tagged_suite)]
+    )
+    short = robotcode_cli(["--root", str(tagged_suite.parent), "discover", "tags", "--tests", str(tagged_suite)])
+    assert abs_str in full.stdout
+    assert abs_str not in short.stdout

tests/robotcode/runner/cli/results/test_diff.py

@@ -212,3 +212,33 @@ def test_diff_identity_yields_no_changes(robotcode_cli: CliRunner, diff_baseline
     assert data.get("statusChanges", []) == []
     assert data.get("added", []) == []
     assert data.get("removed", []) == []
+
+
+# ---------------------------------------------------------------------------
+# --full-paths
+# ---------------------------------------------------------------------------
+
+
+def test_diff_full_paths_keeps_rel_source(
+    robotcode_cli: CliRunner,
+    diff_baseline_output: Path,
+    diff_current_output: Path,
+) -> None:
+    """`--full-paths` doesn't strip `relSource` from the JSON — both
+    fields are always present so consumers have a stable schema."""
+    data = _diff_via_cli(robotcode_cli, diff_baseline_output, diff_current_output, "--full-paths")
+    new_failure = data["newFailures"][0]
+    src = new_failure.get("source")
+    assert src is not None
+    assert Path(src).is_absolute()
+    assert new_failure.get("relSource") is not None
+
+
+def test_diff_default_includes_rel_source(
+    robotcode_cli: CliRunner,
+    diff_baseline_output: Path,
+    diff_current_output: Path,
+) -> None:
+    data = _diff_via_cli(robotcode_cli, diff_baseline_output, diff_current_output)
+    new_failure = data["newFailures"][0]
+    assert new_failure.get("relSource") is not None

tests/robotcode/runner/cli/results/test_log.py

@@ -220,13 +220,21 @@ def test_log_max_depth_collapses_text(text_result: CliRunner, basic_output: Path
     assert "--max-depth 1" in plain
 
 
-def test_log_full_paths(json_result: JsonRunner, basic_output: Path) -> None:
-    """`--full-paths` makes `tests[].source` absolute."""
+def test_log_full_paths_keeps_rel_source(json_result: JsonRunner, basic_output: Path) -> None:
+    """`--full-paths` is a TEXT-render hint; JSON keeps both `source`
+    (absolute) and `relSource` so consumers have a stable schema."""
     data = json_result("log", "--full-paths", output_path=basic_output)
     for t in data["tests"]:
         src = t.get("source")
         assert src is not None
         assert Path(src).is_absolute()
+        assert t.get("relSource") is not None
+
+
+def test_log_default_includes_rel_source(json_result: JsonRunner, basic_output: Path) -> None:
+    data = json_result("log", output_path=basic_output)
+    for t in data["tests"]:
+        assert t.get("relSource") is not None
 
 
 # ---------------------------------------------------------------------------

tests/robotcode/runner/cli/results/test_show.py

@@ -185,20 +185,22 @@ def test_show_search_highlight_visible_in_text(text_result: CliRunner, basic_out
 # ---------------------------------------------------------------------------
 
 
-def test_show_full_paths(json_result: JsonRunner, basic_output: Path) -> None:
-    """`--full-paths` makes `tests[].source` an absolute path."""
+def test_show_full_paths_keeps_both_source_fields(json_result: JsonRunner, basic_output: Path) -> None:
+    """`--full-paths` only affects TEXT rendering. JSON always carries
+    both `source` (absolute) and `relSource` (relative-to-cwd or omitted
+    when not anchored) so consumers like the VS Code extension can
+    consistently rely on the schema."""
     data = json_result("show", "--full-paths", output_path=basic_output)
     for t in data["tests"]:
         src = t.get("source")
         assert src is not None
         assert Path(src).is_absolute()
 
 
-def test_show_no_full_paths_uses_relative(json_result: JsonRunner, basic_output: Path) -> None:
-    """Without the flag, sources are tracked relative (or absolute when no anchor)."""
+def test_show_default_includes_rel_source(json_result: JsonRunner, basic_output: Path) -> None:
+    """Without the flag, JSON has both fields (relSource present when
+    the source is anchored under cwd)."""
     data = json_result("show", output_path=basic_output)
-    # We don't assert relative vs absolute strictly — depends on the run cwd —
-    # but the field must at least be present and non-empty for every test.
     for t in data["tests"]:
         assert get_field(t, "source", "relSource") is not None
 

tests/robotcode/runner/cli/results/test_summary.py

@@ -54,3 +54,32 @@ def test_summary_text_output_contains_counts(text_result: CliRunner, basic_outpu
     # Counts are rendered as a line containing the totals
     assert "5" in plain  # total
     assert "FAIL" in plain  # overall status
+
+
+# ---------------------------------------------------------------------------
+# --full-paths
+# ---------------------------------------------------------------------------
+
+
+def test_summary_full_paths_keeps_rel_source(json_result: JsonRunner, basic_output: Path) -> None:
+    """`--full-paths` is a TEXT-rendering hint; JSON always carries
+    both `source` (absolute) and `relSource` so consumers like the
+    VS Code extension can rely on the schema being stable across the
+    flag."""
+    data = json_result("summary", "--failures", "--full-paths", output_path=basic_output)
+    failures = data["failures"]
+    assert failures, "expected at least one failure"
+    failure = failures[0]
+    src = get_field(failure, "source")
+    assert src is not None
+    assert Path(src).is_absolute()
+    # rel_source is *still* present (it would have been omitted under
+    # the old behaviour where `--full-paths` cleared it).
+    assert get_field(failure, "relSource", "rel_source") is not None
+
+
+def test_summary_default_includes_rel_source(json_result: JsonRunner, basic_output: Path) -> None:
+    data = json_result("summary", "--failures", output_path=basic_output)
+    failures = data["failures"]
+    assert failures
+    assert get_field(failures[0], "relSource", "rel_source") is not None