refactor(robot): remove unnecessary finalizers and dispose chain

Remove redundant _release_watchers_finalizer from _ImportEntry — file
watcher cleanup is already handled explicitly by _remove_file_watcher()
during invalidation and by server_shutdown() at LS shutdown.

Remove the _dispose_finalizer/dispose() chain through ImportsManager,
DocumentsCacheHelper, RobotFrameworkLanguageProvider, CodeAnalyzer, and
CLI. With the per-entry finalizers gone, these only cleared dicts that
Python already cleans up at process exit.

Fix broken finalizer in Workspace.add_file_watchers() where the closure
captured the entry object, preventing it from ever being garbage
collected.

Set atexit=False on sentinel finalizers so they only fire during normal
GC (needed for LS live cleanup), not at interpreter shutdown.

Author: d-biehl

packages/analyze/src/robotcode/analyze/code/cli.py

@@ -398,13 +398,14 @@ def code(
 
         result_collector = ResultCollector(mask)
         result_collector.start()
+        analyzer = CodeAnalyzer(
+            app=app,
+            analysis_config=analyzer_config.to_workspace_analysis_config(),
+            robot_profile=robot_profile,
+            root_folder=root_folder,
+        )
         try:
-            for e in CodeAnalyzer(
-                app=app,
-                analysis_config=analyzer_config.to_workspace_analysis_config(),
-                robot_profile=robot_profile,
-                root_folder=root_folder,
-            ).run(paths=paths, filter=filter):
+            for e in analyzer.run(paths=paths, filter=filter):
                 result_collector.add_diagnostics_report(e)
 
             for e in result_collector.diagnostics:

packages/language_server/src/robotcode/language_server/common/parts/workspace.py

@@ -415,14 +415,6 @@ def _done(f: Task[None]) -> None:
                     # TODO: implement own filewatcher if not supported by language server client
                     self._logger.warning("client did not support workspace/didChangeWatchedFiles.")
 
-            def remove() -> None:
-                try:
-                    self.remove_file_watcher_entry(entry)
-                except RuntimeError:
-                    pass
-
-            weakref.finalize(entry, remove)
-
             self._file_watchers.add(entry)
 
             return entry

packages/robot/src/robotcode/robot/diagnostics/imports_manager.py

@@ -113,30 +113,15 @@ def __init__(self, parent: "ImportsManager") -> None:
         self.references: weakref.WeakSet[Any] = weakref.WeakSet()
         self.file_watchers: List[FileWatcherEntry] = []
         self._lock = RLock(default_timeout=120, name="ImportEntryLock")
-        self._release_watchers_finalizer = weakref.finalize(
-            self,
-            _ImportEntry._release_watchers,
-            self.file_watchers,
-            parent.file_watcher_manager,
-        )
-
-    @staticmethod
-    def _release_watchers(
-        watchers: List[FileWatcherEntry],
-        manager: FileWatcherManagerBase,
-    ) -> None:
-        for watcher in watchers:
-            try:
-                manager.remove_file_watcher_entry(watcher)
-            except RuntimeError:
-                pass
-        watchers.clear()
 
     def _remove_file_watcher(self) -> None:
         if self.file_watchers:
             for watcher in self.file_watchers:
-                self.parent.file_watcher_manager.remove_file_watcher_entry(watcher)
-        self.file_watchers.clear()
+                try:
+                    self.parent.file_watcher_manager.remove_file_watcher_entry(watcher)
+                except RuntimeError:
+                    pass
+            self.file_watchers.clear()
 
     @abstractmethod
     def check_file_changed(self, changes: List[FileEvent]) -> Optional[FileChangeType]: ...
@@ -1429,7 +1414,8 @@ def get_libdoc_for_library_import(
             entry = self._libaries[entry_key]
 
             if not entry.ignore_reference and sentinel is not None and sentinel not in entry.references:
-                weakref.finalize(sentinel, self.__remove_library_entry, entry_key, entry)
+                fin = weakref.finalize(sentinel, self.__remove_library_entry, entry_key, entry)
+                fin.atexit = False  # type: ignore[misc]
                 entry.references.add(sentinel)
 
             return entry.get_libdoc()
@@ -1660,7 +1646,8 @@ def get_libdoc_for_variables_import(
 
             if sentinel is not None and sentinel not in entry.references:
                 entry.references.add(sentinel)
-                weakref.finalize(sentinel, self.__remove_variables_entry, entry_key, entry)
+                fin = weakref.finalize(sentinel, self.__remove_variables_entry, entry_key, entry)
+                fin.atexit = False  # type: ignore[misc]
 
             return entry.get_libdoc()
 
@@ -1687,7 +1674,8 @@ def _get_entry_for_resource_import(
 
         if sentinel is not None and sentinel not in entry.references:
             entry.references.add(sentinel)
-            weakref.finalize(sentinel, self.__remove_resource_entry, entry_key, entry)
+            fin = weakref.finalize(sentinel, self.__remove_resource_entry, entry_key, entry)
+            fin.atexit = False  # type: ignore[misc]
 
         return entry