Merge branch 'master' into dependabot

Author: emanlove

.github/workflows/CI.yml

@@ -1,6 +1,6 @@
 name: SeleniumLibrary CI
 
-on: [push, pull_request]
+on: workflow_dispatch
 
 jobs:
   build:
@@ -9,10 +9,11 @@ jobs:
     continue-on-error: true
     strategy:
       matrix:
-        python-version: [3.8, 3.12]  # pypy-3.9
-        rf-version: [6.1.1, 7.0.1]
-        selenium-version: [4.21.0, 4.22.0, 4.23.1, 4.24.0]
-        browser: [firefox, chrome, headlesschrome]  #edge
+        python-version: [3.9.23, 3.13.5, 3.14.0-rc.3]  # pypy-3.9
+        # python-version: [{earliest: 3.9}, {latest: 3.13.0}]  # pypy-3.9
+        rf-version: [6.1.1, 7.3.2]
+        selenium-version: [4.28.1, 4.29.0, 4.30.0, 4.31.0, 4.32.0, 4.33.0, 4.34.2]
+        browser: [chrome]  # firefox, chrome, headlesschrome, edge
 
     steps:
     - uses: actions/checkout@v4
@@ -21,9 +22,11 @@ jobs:
       with:
         python-version: ${{ matrix.python-version }}
     - name: Setup Chrome
-      uses: browser-actions/setup-chrome@latest
+      uses: browser-actions/setup-chrome@v1
       with:
-        chrome-version: latest
+        chrome-version: 138
+        install-dependencies: true
+        install-chromedriver: true
       id: setup-chrome
     - run: |
         echo Installed chromium version: ${{ steps.setup-chrome.outputs.chrome-version }}
@@ -75,8 +78,13 @@ jobs:
       run: |
         xvfb-run --auto-servernum python atest/run.py --nounit --zip headlesschrome
 
-    - name: Run tests with ${{ matrix.browser }} if CPython
-      if: startsWith( matrix.python-version, 'pypy') == false
+    # - name: Run tests with ${{ matrix.browser }} if CPython
+    #   if: startsWith( matrix.python-version, 'pypy') == false
+    #   run: |
+    #     xvfb-run --auto-servernum python atest/run.py --zip ${{ matrix.browser }}
+
+    - name: Run tests with latest python and latest robot framework
+      if: matrix.python-version == '3.13.0' && matrix.rf-version == '7.2.2'
       run: |
         xvfb-run --auto-servernum python atest/run.py --zip ${{ matrix.browser }}
 
@@ -87,8 +95,9 @@ jobs:
     #     sudo chmod u+x ./selenium-server-standalone.jar
     #     xvfb-run --auto-servernum python atest/run.py --zip headlesschrome  --grid True
 
-    - uses: actions/upload-artifact@v3
+    - uses: actions/upload-artifact@v4
       if: failure()
       with:
-        name: SeleniumLibrary Test results
+        name: sl_$${{ matrix.python-version }}_$${{ matrix.rf-version }}_$${{ matrix.selenium-version }}_$${{ matrix.browser }}
         path: atest/zip_results
+        overwrite: true

.github/workflows/Select.yml

@@ -0,0 +1,79 @@
+name: Selected Test Configuration Matrix
+
+on: [push, pull_request]
+
+jobs:
+  test_config:
+    runs-on: ubuntu-latest
+    continue-on-error: true
+    strategy:
+      matrix:
+        config:
+          - description: latest
+            python-version: 3.13.10
+            rf-version: 7.4.1
+            selenium-version:  4.39.0
+            browser: chrome
+          - description: previous
+            python-version: 3.12.12
+            rf-version: 7.3.2
+            selenium-version: 4.38.0
+            browser: chrome
+          - description: older_rf_version
+            python-version: 3.11.14
+            rf-version: 6.1.1
+            selenium-version: 4.37.0
+            browser: chrome
+
+    steps:
+    - uses: actions/checkout@v4
+    - name: Configuration Description
+      run: |
+        echo "${{ matrix.config.description }} configuration"
+        echo "Testing with RF v${{ matrix.config.rf-version }}, Selenium v${{ matrix.config.selenium-version}}, Python v${{ matrix.config.python-version }} under ${{ matrix.config.browser }}"
+    - name: Set up Python ${{ matrix.config.python-version }}
+      uses: actions/setup-python@v5
+      with:
+        python-version: ${{ matrix.config.python-version }}
+    - name: Setup ${{ matrix.config.browser }} browser
+      uses: browser-actions/setup-chrome@v1
+      with:
+        chrome-version: latest
+        install-dependencies: true
+      id: setup-chrome
+    - run: |
+        echo Installed chromium version: ${{ steps.setup-chrome.outputs.chrome-version }}
+        ${{ steps.setup-chrome.outputs.chrome-path }} --version
+    - name: Setup firefox
+      id: setup-firefox
+      uses: browser-actions/setup-firefox@v1
+      with:
+        firefox-version: latest
+    - run: |
+        echo Installed firefox versions: ${{ steps.setup-firefox.outputs.firefox-version }}
+        ${{ steps.setup-firefox.outputs.firefox-path }} --version
+    - name: Start xvfb
+      run: |
+        export DISPLAY=:99.0
+        Xvfb -ac :99 -screen 0 1280x1024x16 > /dev/null 2>&1 &
+    - name: Install dependencies
+      run: |
+        python -m pip install --upgrade pip
+        pip install -r requirements-dev.txt
+    - name: Install Seleninum v${{ matrix.config.selenium-version }}
+      run: |
+        pip install --upgrade selenium==${{ matrix.config.selenium-version }}
+    - name: Install RF ${{ matrix.config.rf-version }}
+      run: |
+        pip install -U --pre robotframework==${{ matrix.config.rf-version }}
+
+    - name: Run tests under specified config
+      run: |
+        xvfb-run --auto-servernum python atest/run.py --zip ${{ matrix.config.browser }}
+
+    - uses: actions/upload-artifact@v4
+      if: failure()
+      with:
+        name: sl_$${{ matrix.config.python-version }}_$${{ matrix.config.rf-version }}_$${{ matrix.config.selenium-version }}_$${{ matrix.config.browser }}
+        path: atest/zip_results
+        overwrite: true

README.rst

@@ -10,7 +10,7 @@ SeleniumLibrary_ is a web testing library for `Robot Framework`_ that
 utilizes the Selenium_ tool internally. The project is hosted on GitHub_
 and downloads can be found from PyPI_.
 
-SeleniumLibrary currently works with Selenium 4. It supports Python 3.8 through 3.12.
+SeleniumLibrary currently works with Selenium 4. It supports Python 3.8 through 3.13.
 In addition to the normal Python_ interpreter, it works also
 with PyPy_.
 
@@ -44,8 +44,7 @@ The recommended installation method is using pip_::
     pip install --upgrade robotframework-seleniumlibrary
 
 Running this command installs also the latest Selenium and Robot Framework
-versions, but you still need to install `browser drivers`_ separately.
-The ``--upgrade`` option can be omitted when installing the library for the
+versions. The ``--upgrade`` option can be omitted when installing the library for the
 first time.
 
 It is possible to install directly from the GitHub_ repository. To install
@@ -64,39 +63,11 @@ using ``pip`` see `its own documentation <pip_>`__.
 Browser drivers
 ---------------
 
-After installing the library, you still need to install browser and
-operating system specific browser drivers for all those browsers you
-want to use in tests. These are the exact same drivers you need to use with
-Selenium also when not using SeleniumLibrary. More information about
-drivers can be found from `Selenium documentation`__.
-
-The general approach to install a browser driver is downloading a right
-driver, such as ``chromedriver`` for Chrome, and placing it into
-a directory that is in PATH__. Drivers for different browsers
-can be found via Selenium documentation or by using your favorite
-search engine with a search term like ``selenium chrome browser driver``.
-New browser driver versions are released to support features in
-new browsers, fix bug, or otherwise, and you need to keep an eye on them
-to know when to update drivers you use.
-
-Alternatively, you can use a tool called WebdriverManager__ which can
-find the latest version or when required, any version of appropriate
-webdrivers for you and then download and link/copy it into right
-location. Tool can run on all major operating systems and supports
-downloading of Chrome, Firefox, Opera & Edge webdrivers.
-
-Here's an example:
-
-.. code:: bash
-
-      pip install webdrivermanager
-      webdrivermanager firefox chrome --linkpath /usr/local/bin
-
-
+Browsers and drivers are installed and managed automatically by `Selenium Manager`__.
+For more information, see the `Selenium documentation`__.
 
+__ https://www.selenium.dev/documentation/selenium_manager
 __ https://seleniumhq.github.io/selenium/docs/api/py/index.html#drivers
-__ https://en.wikipedia.org/wiki/PATH_(variable)
-__ https://github.com/omenia/webdrivermanager
 
 Usage
 -----

atest/acceptance/keywords/alerts.robot

@@ -43,7 +43,7 @@ Handle Alert returns message
 
 Handle Alert with custom timeout
     Click Button    Slow alert
-    Handle Alert    timeout=1s
+    Handle Alert    timeout=2s
     Click Button    Slow alert
     Run Keyword And Expect Error
     ...    Alert not found in 1 millisecond.

atest/acceptance/keywords/cookies.robot

@@ -36,15 +36,21 @@ Add Cookie When Secure Is False
     Should Be Equal    ${cookie.secure}       ${False}
 
 Add Cookie When Expiry Is Epoch
-    Add Cookie    Cookie1    value1    expiry=1730205247
+    # To convert epoch to formatted string
+    #    from time import strftime, localtime
+    #    strftime('%Y-%m-%d %H:%M:%S', localtime(1793247900))
+    # To update time each September (as Chrome limits cookies to one year expiry date) use
+    #    import datetime
+    #    print (datetime.datetime.strptime("2027-10-29 12:25:00", "%Y-%m-%d %I:%M:%S").timestamp())
+    Add Cookie    Cookie1    value1    expiry=1793247900
     ${cookie} =    Get Cookie    Cookie1
-    ${expiry} =    Convert Date    ${1730205247}    exclude_millis=True
+    ${expiry} =    Convert Date    ${1793247900}    exclude_millis=True
     Should Be Equal As Strings    ${cookie.expiry}    ${expiry}
 
 Add Cookie When Expiry Is Human Readable Data&Time
-    Add Cookie    Cookie12    value12    expiry=2024-10-29 19:36:51
+    Add Cookie    Cookie12    value12    expiry=2026-10-29 12:25:00
     ${cookie} =    Get Cookie    Cookie12
-    Should Be Equal As Strings    ${cookie.expiry}    2024-10-29 19:36:51
+    Should Be Equal As Strings    ${cookie.expiry}    2026-10-29 12:25:00
 
 Delete Cookie
     [Tags]    Known Issue Safari
@@ -114,17 +120,20 @@ Test Get Cookie Keyword Logging
     ...    domain=localhost
     ...    secure=False
     ...    httpOnly=False
-    ...    expiry=2024-09-15 *:22:33
+    ...    expiry=2026-09-01 *:25:00
     ...    extra={'sameSite': 'Lax'}
     ${cookie} =    Get Cookie     far_future
 
 *** Keywords ***
 Add Cookies
+    # To update time each September (as Chrome limits cookies to one year expiry date) use
+    #    import datetime
+    #    print (datetime.datetime.strptime("2027-09-01 12:25:00", "%Y-%m-%d %I:%M:%S").timestamp())
     Delete All Cookies
     Add Cookie    test       seleniumlibrary
     ${now} =    Get Current Date
     ${tomorrow_thistime} =    Add Time To Date    ${now}    1 day
     ${tomorrow_thistime_datetime} =    Convert Date    ${tomorrow_thistime}    datetime
     Set Suite Variable    ${tomorrow_thistime_datetime}
     Add Cookie    another    value   expiry=${tomorrow_thistime}
-    Add Cookie    far_future    timemachine    expiry=1726399353    # 2024-09-15 11:22:33
+    Add Cookie    far_future    timemachine    expiry=1788236700    # 2026-09-01 12:25:00

atest/acceptance/keywords/expected_conditions.robot

@@ -10,7 +10,7 @@ Wait For Expected Conditions One Argument
     Title Should Be    Delayed
 
 Wait For Expected Condition Times out within set timeout
-    [Documentation]  FAIL REGEXP: TimeoutException: Message: Expected Condition not met within set timeout of 0.3*
+    [Documentation]  FAIL STARTS: TimeoutException: Message: Expected Condition not met within set timeout of 0.3
     Title Should Be    Original
     Click Element    link=delayed change title
     Wait For Expected Condition   title_is  Delayed  timeout=0.3

atest/acceptance/keywords/mouse.robot

@@ -8,6 +8,7 @@ Resource          ../resource.robot
 Mouse Over
     [Tags]    Known Issue Safari
     Mouse Over    el_for_mouseover
+    Sleep  0.1secs
     Textfield Value Should Be    el_for_mouseover    mouseover el_for_mouseover
     Run Keyword And Expect Error
     ...    Element with locator 'not_there' not found.
@@ -16,6 +17,7 @@ Mouse Over
 Mouse Over Error
     [Tags]    Known Issue Safari
     Mouse Over    el_for_mouseover
+    Sleep  0.1secs
     Textfield Value Should Be    el_for_mouseover    mouseover el_for_mouseover
     Run Keyword And Expect Error
     ...    Element with locator '鱼在天空中飞翔' not found.

atest/acceptance/keywords/run_on_failure.robot

@@ -67,7 +67,7 @@ Run on Failure Returns Previous Value
     Should Be Equal    ${old}    Log Title
 
 Run On Failure also fails
-    [Documentation]    LOG 2.1 WARN Keyword 'Failure During Run On failure' could not be run on failure: Expected error.
+    [Documentation]    LOG 2.1.2 WARN Keyword 'Failure During Run On failure' could not be run on failure: Expected error.
     Register Keyword to Run on Failure    Failure During Run On failure
     Run Keyword And Expect Error
     ...    ${FAILURE MESSAGE}

atest/acceptance/keywords/textfields.robot

@@ -1,4 +1,5 @@
 *** Settings ***
+Suite Setup       Open Browser To Start Page Disabling Chrome Leaked Password Detection
 Test Setup        Go To Page "forms/prefilled_email_form.html"
 Resource          ../resource.robot
 Force Tags        Known Issue Internet Explorer
@@ -75,3 +76,10 @@ Press Key
 
 Attempt Clear Element Text On Non-Editable Field
     Run Keyword And Expect Error    *    Clear Element Text    can_send_email
+
+*** Keywords ***
+
+Open Browser To Start Page Disabling Chrome Leaked Password Detection
+    [Arguments]    ${alias}=${None}
+    Open Browser    ${FRONT PAGE}    ${BROWSER}    remote_url=${REMOTE_URL}
+    ...    options=add_experimental_option("prefs", {"profile.password_manager_leak_detection": False})    alias=${alias}

atest/acceptance/locators/custom.robot

@@ -55,4 +55,4 @@ Teardown Custom Locator
 Custom Locator Strategy
     [Arguments]    ${browser}    ${locator}    ${tag}    ${constraints}
     ${element}=    Execute Javascript    return window.document.getElementById('${locator}') || [];
-    [Return]    ${element}
+    RETURN    ${element}