Led fix#246
Open
SnappyRiffs wants to merge 3 commits into
Open
Conversation
Add flashWhileHeld method to control LED flashing based on button hold.
Updated readyToShoot command to use flashWhileHeld instead of flashCommand. flashCommand is now a fallback if flashWhileHeld doesnt work
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new flashWhileHeld method to the LEDSubsystem and updates the LED bindings in Controls.java. A review comment identified several critical issues in the implementation: a typo in the subsystem name, an incorrect number of arguments passed to the new method, and the use of onFalse instead of whileFalse, which would cause the command to run indefinitely and block other LED operations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this should work