sshcontroller: Print collected output on command error#160
Open
auscompgeek wants to merge 2 commits into
Open
Conversation
virtuald
reviewed
Mar 1, 2026
Member
Author
|
One of my team members got another JSONDecodeError from get_rio_py_packages just yesterday. Does this look reasonable to you @virtuald? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On deploy, the Python script from
get_rio_py_packagescan sometimes fail, likely due to aMemoryErrorwhen deploying to a roboRIO 1.robotpy-installer/robotpy_installer/roborio_utils.py
Lines 92 to 100 in 44fdc6d
Print the error message from the robot in this scenario.