magicbot: Add tunable update listener method#136
Draft
auscompgeek wants to merge 4 commits intorobotpy:mainfrom
Draft
magicbot: Add tunable update listener method#136auscompgeek wants to merge 4 commits intorobotpy:mainfrom
auscompgeek wants to merge 4 commits intorobotpy:mainfrom
Conversation
This adds a way to add a callback for NT updates to tunables.
auscompgeek
force-pushed
the
tunable-callback
branch
from
3163c0c to
af0809a
Compare
virtuald
reviewed
Feb 28, 2019
Member
virtuald
left a comment
virtuald
left a comment
There was a problem hiding this comment.
One objection I have with this implementation is adding an additional entry listener. As you add more of them it'll keep making callbacks more expensive (which is a problem with the current ntcore implementation... ).
auscompgeek
force-pushed
the
tunable-callback
branch
from
fa08017 to
ee2ba91
Compare
Member
Author
|
@virtuald Now that we have pyntcore, do you still have objections to this? |
Member
|
Callbacks still have the same issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a way to add a callback for NT updates to tunables.
Ref: #133