Support for RSASSA-PSS#266
Open
danielk117-work wants to merge 20 commits into
Open
Conversation
…is used in composer context
Add Rsassa-Pss / PKCS#1 v2 Signature via usage of phpseclib
Switch to GitHub actions
# Conflicts: # .github/workflows/ci.yml
Owner
|
@danielk117-work Can you merge in the latest changes to main to possibly resolve the conflict its reporting for the PR? I was adding some of the support to get the tests to pass but no idea what its considering a conflict. The only possible one would be where I added the phpseclib require in the composer file which should be identical |
# Conflicts: # composer.json
Author
|
I've merged the latest changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@robrichards As requested in #263 (comment), here is a PR for support RSASSA-PSS based XML signature algorithms via usage of the RSA implementation of phpseclib.
It is based on the PR #222.
Our fork is currently used in our fork of lightSAML.