Added RSAKeyValue to KeyInfo element

[hiddewie]

In Issue #74 I saw a feature was requested to add a RSAKeyValue to a signature. This piece of code adds that feature.

I've also updated a single test.

[hiddewie]

Is this PR being looked at? This repository does not seem very active.

[gfaust-qb]

@robrichards is mostly very busy but @Maks3w often looks, categorizes and reviews very often, but it takes time until Rob merges the PRs.

[robrichards]

@hiddewie I have looked at it but am making some changes to it as I've run into a couple cases where it fails to work against certain backends when the cert is also included so need to make those optional. I just haven't had time to finish the code and go through testing it yet. Limited time for another 3 more weeks

[hiddewie]

Thank you for the quick response.

No problem if it takes some time, as long as people look into it.

[jlopezmazzeira]

Hi, how do I implement this method? What function should I use, I can not find the way to implement it, greetings

[hiddewie]

This is a pull request so the functionality is still under consideration by the package maintainer @robrichards.

Please open a separate issue or send an email to the author for library specific questions.

[solidevolution]

What about the PR? Or did someone a fork? This is 2 years old!

[hiddewie]

As far as I am concerned I am open for comments on the PR. However, the maintainer has commented no more since the first comment so I am unsure of the current status or the existance of a fork.

[robrichards]

@hiddewie Can you just make adding those optional where default behavior is not to add them so that current behavior is maintained

[hiddewie]

@robrichards I've added an option, which preserves the original behavour. The original test has been restored (xml-sign.phpt) and an extra one has been added with the updated XML content (the public key info).