Skip to content

Commit 4fd16f1

Browse files
author
juri
committed
Add option for min diff for shorter result list and tresholds
1 parent a660838 commit 4fd16f1

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

robusta_krr/core/runner.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,10 +55,11 @@ def _meets_filter_criteria(
5555

5656
# Absolute difference check
5757
try:
58+
abs_diff_raw = abs(recommended - current)
5859
if resource == ResourceType.CPU:
59-
abs_diff = abs(recommended - current) * 1000
60+
abs_diff = abs_diff_raw * 1000
6061
else:
61-
abs_diff = abs(recommended - current) / (1024**2)
62+
abs_diff = abs_diff_raw / (1024**2)
6263
except TypeError:
6364
logger.error(
6465
f"TypeError: current_val: {current_val}, recommended_val: {recommended_val}, min_diff: {min_diff}, min_percent: {min_percent}")
@@ -69,7 +70,7 @@ def _meets_filter_criteria(
6970

7071
if min_percent != 0.0:
7172
if current > 0: # Avoid division by zero; if current is 0, any increase is infinite percent
72-
percent_diff = (abs_diff / current) * 100
73+
percent_diff = (abs_diff_raw / current) * 100
7374
if percent_diff < min_percent:
7475
return False
7576

0 commit comments

Comments
 (0)