Skip to content

Commit 1ff3f65

Browse files
[ROB-1848] - Bugfix: add sink param to krr args (#1882)
* add sink param to krr * fix type * another bugfix caught * fix new version --------- Co-authored-by: arik <alon.arik@gmail.com>
1 parent 8488fe6 commit 1ff3f65

1 file changed

Lines changed: 7 additions & 4 deletions

File tree

  • playbooks/robusta_playbooks

playbooks/robusta_playbooks/krr.py

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
from robusta.integrations.prometheus.utils import generate_prometheus_config
3737
from robusta.utils.parsing import format_event_templated_string
3838

39-
IMAGE: str = os.getenv("KRR_IMAGE_OVERRIDE", f"{IMAGE_REGISTRY}/krr:v1.24.0")
39+
IMAGE: str = os.getenv("KRR_IMAGE_OVERRIDE", f"{IMAGE_REGISTRY}/krr:v1.25.1")
4040
KRR_MEMORY_LIMIT: str = os.getenv("KRR_MEMORY_LIMIT", "2Gi")
4141
KRR_MEMORY_REQUEST: str = os.getenv("KRR_MEMORY_REQUEST", "2Gi")
4242
KRR_STRATEGY: str = os.getenv("KRR_STRATEGY", "simple")
@@ -308,7 +308,7 @@ class ProcessScanParams(ActionParams):
308308
scan_type: str
309309
result: Any
310310
scan_id: str
311-
start_time: datetime
311+
start_time: str
312312

313313
def _emit_failed_scan_event(event, scan_id, start_time, metadata, reason_msg, exception=None, result=None):
314314
if exception:
@@ -468,7 +468,10 @@ def krr_scan(event: ExecutionBaseEvent, params: KRRParams):
468468
publish_scan_args = ""
469469
if KRR_PUSH_SCAN:
470470
publish_scan_args = f"--publish_scan_url={KRR_PUBLISH_URL} --scan_id={scan_id} --start_time=\"{start_time}\""
471-
471+
if event.named_sinks:
472+
# Append one flag per sink
473+
for sink in event.named_sinks:
474+
publish_scan_args += f' --named_sinks="{sink}"'
472475

473476
python_command = (
474477
f"python krr.py {params.strategy} {publish_scan_args} {args_sanitized} {additional_flags} "
@@ -537,7 +540,7 @@ def update_state(state: ScanState) -> None:
537540
job_name,
538541
params.timeout,
539542
secret,
540-
custom_annotations=params.custom_annotations,
543+
custom_annotations=krr_annotations,
541544
ttl_seconds_after_finished=43200,
542545
delete_job_post_execution=False,
543546
process_name=False,

0 commit comments

Comments
 (0)