Forward user_id as query param on holmes_feedback

Holmes' POST /api/feedback reads user_id from request.query_params, not
the JSON body (mirrors /api/chat's resolution path used by the relay).
Posting it in the body returns 400 "missing user_id". Pull user_id out
of the action params and forward it via the URL query string.

- Declare user_id: Optional[str] on HolmesFeedbackParams so it's
  discoverable; pop it before constructing the request body.
- Update tests to assert user_id is on params= and not in the body.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: alonelish

src/robusta/core/model/base_params.py

@@ -253,6 +253,7 @@ class HolmesFeedbackParams(HolmesParams):
     sentiment: Literal["thumbs_up", "thumbs_down"]
     category: Optional[str] = None
     comment: Optional[str] = None
+    user_id: Optional[str] = None
 
     class Config:
         extra = "allow"

src/robusta/core/playbooks/internal/ai_integration.py

@@ -445,11 +445,16 @@ def holmes_feedback(event: ExecutionBaseEvent, params: HolmesFeedbackParams):
         )
 
     try:
+        # Holmes reads user_id from the query string (not the body) on
+        # /api/feedback — see server.py's `query_params.get("user_id")`.
+        # Pull it out of the params and forward as a URL query param.
         params_dict = params.dict(exclude={"holmes_url", "model"})
+        user_id = params_dict.pop("user_id", None)
         holmes_req = HolmesFeedbackRequest(**params_dict)
         result = requests.post(
             f"{holmes_url}/api/feedback",
             data=holmes_req.json(),
+            params={"user_id": user_id} if user_id else None,
             timeout=30,
         )
         result.raise_for_status()

tests/test_ai_integration.py

@@ -221,6 +221,7 @@ def test_holmes_feedback_posts_correct_body(mock_post, mock_event):
         sentiment="thumbs_down",
         category="wrong_answer",
         comment="missed the actual cause",
+        user_id="u-42",
         holmes_url="http://test-holmes:8080",
     )
 
@@ -238,6 +239,9 @@ def test_holmes_feedback_posts_correct_body(mock_post, mock_event):
     # holmes_url and model are runner-only and must NOT be forwarded
     assert "holmes_url" not in body
     assert "model" not in body
+    # user_id goes on the query string, not the body — Holmes reads it from query_params
+    assert "user_id" not in body
+    assert call_args[1]["params"] == {"user_id": "u-42"}
 
     mock_event.add_finding.assert_called_once()
 
@@ -260,6 +264,8 @@ def test_holmes_feedback_minimal_body(mock_post, mock_event):
     assert body["sentiment"] == "thumbs_up"
     assert body["category"] is None
     assert body["comment"] is None
+    # No user_id supplied → no params kwarg sent (don't forge an empty user_id)
+    assert mock_post.call_args[1]["params"] is None
 
 
 def test_holmes_feedback_missing_request_id_raises():