Fixed bug in send_finding_slack

Author: itisallgood

src/robusta/core/playbooks/internal/ai_integration.py

@@ -113,12 +113,11 @@ def ask_holmes(event: ExecutionBaseEvent, params: AIInvestigateParams):
                 [HolmesResultsBlock(holmes_result=holmes_result)], enrichment_type=EnrichmentType.ai_analysis
             )
             runner_context = getattr(params, "robusta_context", None)
-            if runner_context and "thread_ts" in runner_context:
-                original_thread_ts = runner_context.get("thread_ts")
-                original_channel_id = runner_context.get("channel_id")
-                if original_thread_ts:                    
-                    finding.robusta_context["thread_ts"] = original_thread_ts
-                    finding.robusta_context["channel_id"] = original_channel_id
+            if runner_context:
+                if "thread_ts" in runner_context:
+                    finding.robusta_context["thread_ts"] = runner_context.get("thread_ts")
+                if "channel_id" in runner_context:
+                    finding.robusta_context["channel_id"] = runner_context.get("channel_id")
 
             event.add_finding(finding)
 

src/robusta/core/reporting/base.py

@@ -9,7 +9,6 @@
 from typing import Any, Dict, List, Optional, Union
 from urllib.parse import urlencode
 
-from pydantic import Field
 from pydantic.main import BaseModel
 from strenum import StrEnum
 

src/robusta/core/reporting/callbacks.py

@@ -5,7 +5,7 @@
 from robusta.core.playbooks.actions_registry import Action
 from robusta.core.reporting import CallbackChoice
 from robusta.core.reporting.action_requests import ActionRequestBody, ExternalActionRequest, sign_action_request
-import logging
+
 
 class ExternalActionRequestBuilder(BaseModel):
     @classmethod

src/robusta/integrations/slack/sender.py

@@ -603,13 +603,13 @@ def send_finding_to_slack(
         blocks: List[BaseBlock] = []
         attachment_blocks: List[BaseBlock] = []
 
-        channel_id, thread_ts = self._resolve_slack_thread(
+        slack_channel, thread_ts = self._resolve_slack_thread(
             finding, sink_params, thread_ts
         )
 
         if finding.finding_type == FindingType.AI_ANALYSIS:
             # holmes analysis message needs special handling
-            self.send_holmes_analysis(finding, channel_id, platform_enabled, thread_ts)
+            self.send_holmes_analysis(finding, slack_channel, platform_enabled, thread_ts)
             return ""  # [arik] Looks like the return value here is not used, needs to be removed
 
         status: FindingStatus = (