refactoring holmes

Author: Avi-Robusta

src/robusta/core/sinks/robusta/dal/supabase_dal.py

@@ -753,3 +753,23 @@ def set_cluster_active(self, active: bool) -> None:
             )
         except Exception as e:
             logging.error(f"Failed to set cluster status active=False error: {e}")
+
+    def holmes_slackbot_enabled(
+        self, account_id: str
+    ) -> bool:
+        try:
+            res = self.client.rpc(
+                "holmes_slackbot_enabled",
+                {"_account_id": account_id},
+            ).execute()
+
+            logging.debug(f"Holmes Slackbot connected {bool(res.data)}")
+            return bool(res.data)
+
+        except Exception as error:
+            logging.error(
+                f"Unexpected error rpc holmes_slackbot_enabled."
+                f"account_id: {account_id}",
+                exc_info=True,
+            )
+            raise error

src/robusta/integrations/slack/sender.py

@@ -542,7 +542,17 @@ def send_holmes_analysis(
         except Exception:
             logging.exception(f"error sending message to slack. {title}")
 
-    def send_finding_to_slack(
+    def get_holmes_block(self, platform_enabled: bool, slackbot_enabled) -> Optional[MarkdownBlock]:
+        if not platform_enabled and not slackbot_enabled:
+            return MarkdownBlock("_Ask AI questions about this alert, by connecting <https://platform.robusta.dev/create-account|Robusta SaaS> and tagging @holmes._")
+        elif platform_enabled and not slackbot_enabled:
+            return MarkdownBlock("_Ask AI questions about this alert, by adding @holmes to your <https://docs.robusta.dev/master/configuration/holmesgpt/index.html#enable-holmes-in-slack-in-the-platform|Slack>._")
+        elif platform_enabled and slackbot_enabled:
+            return MarkdownBlock("_Ask AI questions about this alert, by tagging @holmes in a threaded reply_")
+        return None
+
+
+def send_finding_to_slack(
         self,
         finding: Finding,
         sink_params: SlackSinkParams,
@@ -601,18 +611,14 @@ def send_finding_to_slack(
 
         blocks.append(DividerBlock())
 
+        holmes_block = self.get_holmes_block(platform_enabled, HOLMES_ENABLED)
+        if holmes_block:
+            blocks.append(holmes_block)
+
+
         if len(attachment_blocks):
             attachment_blocks.append(DividerBlock())
 
-        if not platform_enabled and not HOLMES_ENABLED:
-            blocks.append(MarkdownBlock("_Ask AI questions about this alert, by connecting <https://platform.robusta.dev/create-account|Robusta SaaS> and tagging @holmes._"))
-        elif platform_enabled and not HOLMES_ENABLED:
-            blocks.append(
-                MarkdownBlock("_Ask AI questions about this alert, by adding @holmes to your <https://docs.robusta.dev/master/configuration/holmesgpt/index.html#enable-holmes-in-slack-in-the-platform|Slack>._"))
-        elif platform_enabled and HOLMES_ENABLED:
-            blocks.append(
-                MarkdownBlock("_Ask AI questions about this alert, by tagging @holmes in a threaded reply_"))
-
         return self.__send_blocks_to_slack(
             blocks,
             attachment_blocks,
@@ -624,6 +630,7 @@ def send_finding_to_slack(
             thread_ts=thread_ts,
         )
 
+
     def send_or_update_summary_message(
         self,
         group_by_classification_header: List[str],