pr changes

Author: Avi-Robusta

docs/configuration/sinks/Opsgenie.rst

@@ -26,7 +26,9 @@ The OpsGenie sink supports static and dynamic team routing, optional fallback te
             api_key: OpsGenie integration API key  # configured from OpsGenie team integration
             teams:
             - "noc"                  # Static team
-            - "$labels.team"         # Dynamic team routing based on alert label
+            - "$labels.team"  # Dynamic routing based on alert labels or annotations.
+                              # For example, if an alert subject has `team=infra`, it routes to the "infra" team.
+                              # Use $labels.<label_name> or $annotations.<label_name> as placeholders.
             default_team: "oncall"   # Optional fallback team for Dynamic team routing
             tags:
             - "prod a"

src/robusta/core/sinks/opsgenie/opsgenie_sink.py

@@ -97,25 +97,25 @@ def __get_teams(self, finding: Finding) -> List[str]:
                         finding.subject.labels,
                         finding.subject.annotations,
                     )
-                    if team:  # Only add non-null teams
+                    if team and team not in teams:  # Only add non-null, de-duped teams
                         teams.append(team)
                 else:
                     # Use static team name directly
-                    teams.append(team_template)
+                    if team_template not in teams:  # Only add de-duped teams
+                        teams.append(team_template)
             except Exception as e:
                 logging.warning(
                     f"Failed to process team template {team_template} for alert subject {finding.service_key}: {e}"
                 )
                 continue
 
         # If no teams were resolved and we have a default team, use it
-        if not teams and self.default_team:
+        if not teams and self.default_team and self.default_team not in teams:
             teams.append(self.default_team)
         elif not teams and self.teams:  # dynamic routing failed and no default team configured
             logging.warning(f"No valid teams resolved for finding {finding.title}. Alert may not be routed properly.")
 
-        # Remove duplicates
-        return list(set(teams))
+        return teams
 
     def __open_alert(self, finding: Finding, platform_enabled: bool):
         description = self.__to_description(finding, platform_enabled)

tests/test_opsgenie_sink.py

@@ -60,7 +60,7 @@ def test_get_teams_with_missing_label():
     sink = create_sink(teams=["$labels.team", "$annotations.owner"], default_team="default-team")
     finding = create_finding(labels={"environment": "prod"}, annotations={"owner": "ops-team"})  # missing team label
     teams = sink._OpsGenieSink__get_teams(finding)
-    assert teams == ["ops-team", "default-team"]
+    assert teams == ["default-team", "ops-team"]
 
 
 def test_get_teams_with_missing_annotation():