Skip to content

add option to disable 'Ask Holmes' when holmes is enabled #1751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arikalon1 merged 2 commits into from
Mar 12, 2025
Merged

add option to disable 'Ask Holmes' when holmes is enabled #1751

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff38e98
add option to disable 'Ask Holmes' when holmes is enabled
arikalon1 Mar 12, 2025
5a24cca
Merge branch 'master' into allow-disabling-holmes-button
arikalon1 Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/robusta/core/model/env_vars.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,7 @@ def load_bool(env_var, default: bool):
POD_WAIT_RETRIES_SECONDS = int(os.environ.get("POD_WAIT_RETRIES_SECONDS", 5))

HOLMES_ENABLED = load_bool("HOLMES_ENABLED", False)
HOLMES_ASK_SLACK_BUTTON_ENABLED = load_bool("HOLMES_ASK_SLACK_BUTTON_ENABLED", True)

# simple calculated values (not direct environment vars)
SENTRY_ENABLED = SEND_ADDITIONAL_TELEMETRY and SENTRY_DSN
4 changes: 2 additions & 2 deletions src/robusta/integrations/slack/sender.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
ADDITIONAL_CERTIFICATE,
HOLMES_ENABLED,
SLACK_REQUEST_TIMEOUT,
SLACK_TABLE_COLUMNS_LIMIT,
SLACK_TABLE_COLUMNS_LIMIT, HOLMES_ASK_SLACK_BUTTON_ENABLED,
)
from robusta.core.playbooks.internal.ai_integration import ask_holmes
from robusta.core.reporting.base import Emojis, EnrichmentType, Finding, FindingStatus, LinkType
Expand Down Expand Up @@ -541,7 +541,7 @@ def send_finding_to_slack(
)
blocks.append(links_block)

if HOLMES_ENABLED:
if HOLMES_ENABLED and HOLMES_ASK_SLACK_BUTTON_ENABLED:
blocks.append(self.__create_holmes_callback(finding))

blocks.append(MarkdownBlock(text=f"*Source:* `{self.cluster_name}`"))
Expand Down
Loading