Skip to content

Fix pod evicted enricher nodes table#1819

Merged
Avi-Robusta merged 1 commit intomasterfrom
ROB-1330-failed-to-render-pod-evicted-enricher-evidence-to-slack
May 15, 2025
Merged

Fix pod evicted enricher nodes table#1819
Avi-Robusta merged 1 commit intomasterfrom
ROB-1330-failed-to-render-pod-evicted-enricher-evidence-to-slack

Conversation

@moshemorad
Copy link
Copy Markdown
Contributor

@moshemorad moshemorad commented May 15, 2025

Summary by CodeRabbit

  • Bug Fixes
    • Improved consistency when displaying enrichment information for evicted pods.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 15, 2025

Walkthrough

The change updates the argument passed to the event.add_enrichment method in the pod evicted enrichments playbook. Instead of passing a single enrichment block, the code now passes a list containing the enrichment block, aligning with the method's expected input type.

Changes

File(s) Change Summary
playbooks/robusta_playbooks/pod_evicted_enrichments.py Modified the argument to event.add_enrichment to pass a list containing running_nodes_table

Sequence Diagram(s)

sequenceDiagram
    participant Playbook
    participant Event

    Playbook->>Event: add_enrichment([running_nodes_table])
Loading

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.


Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 83132dc and 4b08b70.

📒 Files selected for processing (1)
  • playbooks/robusta_playbooks/pod_evicted_enrichments.py (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: run_tests
  • GitHub Check: run_tests
  • GitHub Check: Deploy docs
🔇 Additional comments (1)
playbooks/robusta_playbooks/pod_evicted_enrichments.py (1)

59-60: Good fix to properly pass enrichment as a list.

The change correctly updates the call to event.add_enrichment() to pass a list containing the enrichment block rather than passing the block directly. This aligns with how add_enrichment is used elsewhere in the file (see lines 51-55) and ensures consistency in the API usage.

For additional robustness, you might consider adding a check for None before adding the enrichment:

running_nodes_table = get_node_running_pods_table_block_or_none(node)
-event.add_enrichment([running_nodes_table])
+if running_nodes_table is not None:
+    event.add_enrichment([running_nodes_table])

This would prevent adding a [None] enrichment if no running pods table could be generated.

✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Avi-Robusta Avi-Robusta merged commit 8af6d71 into master May 15, 2025
8 checks passed
@Avi-Robusta Avi-Robusta deleted the ROB-1330-failed-to-render-pod-evicted-enricher-evidence-to-slack branch May 15, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants