ROB-1842 add single quote list for helm #1880
Conversation
WalkthroughThe change modifies the Helm template for the runner container by wrapping the JSON value assigned to the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
helm/robusta/templates/runner.yaml (1)
108-108: Remove trailing whitespace to satisfy lintersLine 108 contains only spaces, tripping YAML-lint (
trailing-spaces). Deleting the line (or trimming it) avoids CI failures and keeps the file clean.- +
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
helm/robusta/templates/runner.yaml(1 hunks)
🧰 Additional context used
🪛 YAMLlint (1.37.1)
helm/robusta/templates/runner.yaml
[error] 108-108: trailing spaces
(trailing-spaces)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: run_tests
- GitHub Check: run_tests
- GitHub Check: Deploy docs
🔇 Additional comments (1)
helm/robusta/templates/runner.yaml (1)
106-107: 👍 Good call—squoteprevents the JSON from being parsed as a mapWrapping the
toJsonoutput withsquoteguaranteesCUSTOM_CRDis delivered to the container as a plain string, avoiding the “map-instead-of-string” schema violation Kubernetes would otherwise raise.
No description provided.