Allow disabling the note for connecting Holmes

[arikalon1]

No description provided.

[coderabbitai]

Walkthrough

A new boolean flag, disable_holmes_note, was introduced and threaded through the Slack sink configuration, parameter class, and sender logic. The SlackSender now conditionally omits the Holmes AI note block in Slack messages when this flag is set. No other logic or control flow was altered.

Changes

Cohort / File(s)	Change Summary
Slack Sink Parameter Update src/robusta/core/sinks/slack/slack_sink_params.py	Added disable_holmes_note: bool = False field to SlackSinkParams.
Slack Sink Construction src/robusta/core/sinks/slack/slack_sink.py	Annotated slack_sink_params type; passed disable_holmes_note to SlackSender constructor.
SlackSender Logic src/robusta/integrations/slack/sender.py	Extended SlackSender constructor with disable_holmes_note; message logic now checks this flag.

Sequence Diagram(s)

sequenceDiagram
    participant Config as SlackSinkParams
    participant Sink as SlackSink
    participant Sender as SlackSender
    participant Slack as Slack API

    Config->>Sink: Provide disable_holmes_note flag
    Sink->>Sender: Instantiate with disable_holmes_note
    Sender->>Slack: Send message (Holmes note included only if disable_holmes_note is False)

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

• [ROB-1286] Updated holmes slack format #1826: Both PRs modify SlackSender to control Holmes-related Slack message content, but focus on different aspects of Holmes integration.

Suggested reviewers

• RoiGlinik

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5cdf45f and 3875ba1.

📒 Files selected for processing (3)

• src/robusta/core/sinks/slack/slack_sink.py (1 hunks)
• src/robusta/core/sinks/slack/slack_sink_params.py (1 hunks)
• src/robusta/integrations/slack/sender.py (3 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

src/robusta/core/sinks/slack/slack_sink.py (2)

src/robusta/core/sinks/slack/slack_sink_params.py (2)

• SlackSinkParams (9-27)
• get_params (33-34)

src/robusta/integrations/slack/sender.py (1)

• SlackSender (60-986)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: run_tests
• GitHub Check: run_tests
• GitHub Check: Deploy docs

🔇 Additional comments (6)

src/robusta/core/sinks/slack/slack_sink_params.py (1)

15-15: LGTM! Parameter addition follows best practices.

The new disable_holmes_note boolean parameter is well-defined with an appropriate default value of False that maintains backward compatibility.

src/robusta/core/sinks/slack/slack_sink.py (2)

14-14: Good practice: Explicit type annotation.

Adding explicit type annotation for slack_sink_params improves code readability and helps with IDE support.

---

19-19: LGTM! Parameter correctly threaded through to SlackSender.

The disable_holmes_note parameter is properly passed from SlackSinkParams to the SlackSender constructor, maintaining the data flow as expected.

src/robusta/integrations/slack/sender.py (3)

64-64: LGTM! Constructor parameter addition follows established patterns.

The new disable_holmes_note parameter is correctly added with an appropriate default value that maintains backward compatibility.

---

87-87: LGTM! Proper instance variable assignment.

The parameter is correctly stored as an instance variable for later use in the message sending logic.

---

747-750: LGTM! Conditional logic correctly implements the feature.

The Holmes note block is now conditionally added based on the disable_holmes_note flag. When disable_holmes_note is True, the Holmes block is skipped as intended, while maintaining the existing behavior when the flag is False (default).

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch disable-holmes-note

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[Avi-Robusta]

LGTM