Skip to content

[ROB-1946] Bugfix - Automatic slack Investigation fix#1899

Merged
Avi-Robusta merged 1 commit intomasterfrom
fix_holmes_message
Aug 19, 2025
Merged

[ROB-1946] Bugfix - Automatic slack Investigation fix#1899
Avi-Robusta merged 1 commit intomasterfrom
fix_holmes_message

Conversation

@Avi-Robusta
Copy link
Copy Markdown
Contributor

No description provided.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Aug 19, 2025

Walkthrough

Updated user-facing Slack guidance text in SlackSender.get_holmes_block to remove the "@holmes" mention, replacing it with "holmes" in three return branches. No logic, control flow, or API changes.

Changes

Cohort / File(s) Summary of Changes
Slack Holmes guidance text
src/robusta/integrations/slack/sender.py
Revised literal strings in three branches of get_holmes_block to reference “holmes” instead of “@holmes”; no code logic changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix_holmes_message

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Avi-Robusta Avi-Robusta changed the title Bugfix - Automatic Investigation Bugfix - Automatic Investigation fix Aug 19, 2025
@Avi-Robusta Avi-Robusta changed the title Bugfix - Automatic Investigation fix Bugfix - Automatic slack Investigation fix Aug 19, 2025
@Avi-Robusta Avi-Robusta requested a review from moshemorad August 19, 2025 08:14
@Avi-Robusta Avi-Robusta changed the title Bugfix - Automatic slack Investigation fix [ROB-1946] Bugfix - Automatic slack Investigation fix Aug 19, 2025
@Avi-Robusta Avi-Robusta enabled auto-merge (squash) August 19, 2025 08:15
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
src/robusta/integrations/slack/sender.py (1)

646-651: Avoid accidental Slack mentions; use code formatting for clarity and add consistent punctuation

Great call removing the raw "@holmes" to avoid pinging. For clearer guidance without triggering mentions, consider rendering it as code (@holmes). Also, make punctuation consistent (add a trailing period in the threaded-reply variant and drop the superfluous comma after “alert”).

-            return MarkdownBlock("_Ask AI questions about this alert, by connecting <https://platform.robusta.dev/create-account|Robusta SaaS> and tagging holmes._")
+            return MarkdownBlock("_Ask AI questions about this alert by connecting <https://platform.robusta.dev/create-account|Robusta SaaS> and tagging `@holmes`._")
-            return MarkdownBlock("_Ask AI questions about this alert, by adding holmes to your <https://docs.robusta.dev/master/configuration/holmesgpt/index.html#enable-holmes-in-slack-in-the-platform|Slack>._")
+            return MarkdownBlock("_Ask AI questions about this alert by adding `@holmes` to your <https://docs.robusta.dev/master/configuration/holmesgpt/index.html#enable-holmes-in-slack-in-the-platform|Slack>._")
-            return MarkdownBlock("_Ask AI questions about this alert, by tagging holmes in a threaded reply_")
+            return MarkdownBlock("_Ask AI questions about this alert by tagging `@holmes` in a threaded reply._")
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between c74eb7d and 0b2b434.

📒 Files selected for processing (1)
  • src/robusta/integrations/slack/sender.py (1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
src/robusta/integrations/slack/sender.py (1)
src/robusta/core/reporting/blocks.py (1)
  • MarkdownBlock (42-61)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: run_tests
  • GitHub Check: run_tests
  • GitHub Check: Deploy docs
🔇 Additional comments (1)
src/robusta/integrations/slack/sender.py (1)

646-651: No raw “@holmes” mentions in user-facing code

The only matches are in Sphinx docs (inside code blocks/backticks) and in test fixtures—both intentionally scoped and safe. No actionable changes are needed.

@Avi-Robusta Avi-Robusta merged commit 35f8304 into master Aug 19, 2025
8 checks passed
@Avi-Robusta Avi-Robusta deleted the fix_holmes_message branch August 19, 2025 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants