Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/robusta/core/model/base_params.py
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,10 @@ class ToolApprovalDecision(BaseModel):
class HolmesChatParams(HolmesParams):
"""
:var ask: User's prompt for holmes

This class allows extra fields to be passed through to Holmes.
Any additional parameters received will be forwarded to the Holmes server,
allowing client/server upgrades without requiring changes to this middleware.
"""

ask: str
Expand All @@ -202,6 +206,9 @@ class HolmesChatParams(HolmesParams):
tool_decisions: Optional[List[ToolApprovalDecision]] = None
additional_system_prompt: Optional[str] = None

class Config:
extra = "allow"


class HolmesIssueChatParams(HolmesChatParams):
resource: Optional[ResourceInfo] = ResourceInfo()
Expand Down
13 changes: 4 additions & 9 deletions src/robusta/core/playbooks/internal/ai_integration.py
Original file line number Diff line number Diff line change
Expand Up @@ -418,15 +418,10 @@ def holmes_chat(event: ExecutionBaseEvent, params: HolmesChatParams):
cluster_name = event.get_context().cluster_name

try:
holmes_req = HolmesChatRequest(
ask=params.ask,
conversation_history=params.conversation_history,
model=params.model,
stream=params.stream,
additional_system_prompt=params.additional_system_prompt,
enable_tool_approval=params.enable_tool_approval,
tool_decisions=params.tool_decisions,
)
# Pass through all parameters to Holmes, excluding fields used only by this action
# This allows Holmes clients/servers to add new parameters without requiring updates here
params_dict = params.dict(exclude={"holmes_url", "render_graph_images"})
holmes_req = HolmesChatRequest(**params_dict)
url = f"{holmes_url}/api/chat"
if params.stream:
if params.render_graph_images:
Expand Down
11 changes: 11 additions & 0 deletions src/robusta/core/reporting/holmes.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,14 @@ class HolmesConversationRequest(BaseModel):


class HolmesChatRequest(BaseModel):
"""
Request model for Holmes chat API.

This class allows extra fields to be passed through to Holmes.
Any additional parameters received will be forwarded to the Holmes server,
allowing client/server upgrades without requiring changes to this middleware.
"""

ask: str
conversation_history: Optional[List[dict]] = None
model: Optional[str] = None
Expand All @@ -44,6 +52,9 @@ class HolmesChatRequest(BaseModel):
tool_decisions: Optional[List[ToolApprovalDecision]] = None
additional_system_prompt: Optional[str] = None

class Config:
extra = "allow"


class HolmesIssueChatRequest(HolmesChatRequest):
investigation_result: HolmesInvestigationResult
Expand Down
Loading