Skip to content

allow disabling platform links on webex#2088

Merged
Avi-Robusta merged 1 commit into
masterfrom
webex-platform-links
May 26, 2026
Merged

allow disabling platform links on webex#2088
Avi-Robusta merged 1 commit into
masterfrom
webex-platform-links

Conversation

@arikalon1
Copy link
Copy Markdown
Contributor

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 26, 2026

Docker image ready for 724cec0 (built in 2m 54s)

⚠️ Warning: does not support ARM (ARM images are built on release only - not on every PR)

Use this tag to pull the image for testing.

📋 Copy commands

⚠️ Temporary images are deleted after 30 days. Copy to a permanent registry before using them:

gcloud auth configure-docker us-central1-docker.pkg.dev
docker pull us-central1-docker.pkg.dev/robusta-development/temporary-builds/robusta-runner:724cec0
docker tag us-central1-docker.pkg.dev/robusta-development/temporary-builds/robusta-runner:724cec0 me-west1-docker.pkg.dev/robusta-development/development/robusta-runner-dev:724cec0
docker push me-west1-docker.pkg.dev/robusta-development/development/robusta-runner-dev:724cec0

Patch Helm values in one line:

helm upgrade --install robusta robusta/robusta \
  --reuse-values \
  --set runner.image=me-west1-docker.pkg.dev/robusta-development/development/robusta-runner-dev:724cec0

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 26, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 50859215-018b-4826-bdcc-ad1b5a64e12c

📥 Commits

Reviewing files that changed from the base of the PR and between 1f927f1 and c3eccfe.

📒 Files selected for processing (3)
  • docs/configuration/sinks/webex.rst
  • src/robusta/core/sinks/webex/webex_sink.py
  • src/robusta/core/sinks/webex/webex_sink_params.py

Walkthrough

This PR adds a new disable_platform_links configuration parameter to the Webex sink, allowing operators to prevent platform links from appearing in sent findings. The parameter is defined, enforced in the message flow, and documented.

Changes

Disable Platform Links Feature

Layer / File(s) Summary
Parameter definition and sink enforcement
src/robusta/core/sinks/webex/webex_sink_params.py, src/robusta/core/sinks/webex/webex_sink.py
WebexSinkParams introduces a new boolean field disable_platform_links defaulting to False. The WebexSink.write_finding() method checks this field and overrides platform_enabled to False when the parameter is enabled, preventing platform links regardless of incoming config.
Configuration documentation
docs/configuration/sinks/webex.rst
A new "Configuration parameters" section documents the Webex sink's configurable fields in a table, including the new disable_platform_links behavior toggle alongside required credentials and routing overrides.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~4 minutes

Suggested reviewers

  • Avi-Robusta
🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive No description was provided by the author, making it impossible to assess relevance to the changeset. Add a pull request description explaining the purpose and context of the changes, even if brief.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: adding the ability to disable platform links on the Webex sink.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch webex-platform-links

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Avi-Robusta Avi-Robusta enabled auto-merge (squash) May 26, 2026 07:29
@Avi-Robusta Avi-Robusta merged commit f945b48 into master May 26, 2026
9 checks passed
@Avi-Robusta Avi-Robusta deleted the webex-platform-links branch May 26, 2026 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants