Skip to content

Commit 048aa78

Browse files
authored
Upgrade rocicorp/devcontainer-features/agents to v3 (#64)
agents v3.0.0 is a breaking release that drops the bundled GitHub CLI (gh) and 1Password CLI (op), so the container no longer injects a GitHub token (or 1Password credentials) at shell start. - Bump the agents pin :2 -> :3 in .devcontainer/devcontainer.json - Remove the now-dead GITHUB_TOKEN passthrough in remoteEnv plus the gh/1Password comments. Verified nothing in the repo uses gh or op inside the container (no lifecycle command, script, or in-container CI), so this is behavior-preserving and github-cli was not re-added. - Regenerate .devcontainer/devcontainer-lock.json: agents resolves to the v3 digest and no longer depends on github-cli, so the standalone github-cli lock entry is dropped. claude-code and pnpm are unchanged. - Add .github/dependabot.yml with a devcontainers entry so feature updates are tracked weekly going forward.
1 parent a54fe1e commit 048aa78

3 files changed

Lines changed: 17 additions & 21 deletions

File tree

.devcontainer/devcontainer-lock.json

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -5,18 +5,12 @@
55
"resolved": "ghcr.io/anthropics/devcontainer-features/claude-code@sha256:cfc2e7d3e9fd3b9b01f8d5cb158508a884c8c0ede2e23ed10f32dea5d4ffe69a",
66
"integrity": "sha256:cfc2e7d3e9fd3b9b01f8d5cb158508a884c8c0ede2e23ed10f32dea5d4ffe69a"
77
},
8-
"ghcr.io/devcontainers/features/github-cli:1": {
9-
"version": "1.1.0",
10-
"resolved": "ghcr.io/devcontainers/features/github-cli@sha256:d22f50b70ed75339b4eed1ba9ecde3a1791f90e88d37936517e3bace0bbad671",
11-
"integrity": "sha256:d22f50b70ed75339b4eed1ba9ecde3a1791f90e88d37936517e3bace0bbad671"
12-
},
13-
"ghcr.io/rocicorp/devcontainer-features/agents:2": {
14-
"version": "2.0.0",
15-
"resolved": "ghcr.io/rocicorp/devcontainer-features/agents@sha256:172905cd57fbc946323644a52d5829415c77ff8c6f217594720966efcba11db6",
16-
"integrity": "sha256:172905cd57fbc946323644a52d5829415c77ff8c6f217594720966efcba11db6",
8+
"ghcr.io/rocicorp/devcontainer-features/agents:3": {
9+
"version": "3.0.0",
10+
"resolved": "ghcr.io/rocicorp/devcontainer-features/agents@sha256:cb7bb04455faaab8fa55e5d57656be969f0f59657fee8a3320e61badb025a5a3",
11+
"integrity": "sha256:cb7bb04455faaab8fa55e5d57656be969f0f59657fee8a3320e61badb025a5a3",
1712
"dependsOn": [
18-
"ghcr.io/anthropics/devcontainer-features/claude-code:1",
19-
"ghcr.io/devcontainers/features/github-cli:1"
13+
"ghcr.io/anthropics/devcontainer-features/claude-code:1"
2014
]
2115
},
2216
"ghcr.io/rocicorp/devcontainer-features/pnpm:1": {

.devcontainer/devcontainer.json

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -16,19 +16,12 @@
1616
"workspaceFolder": "/workspaces/hello-zero",
1717
"shutdownAction": "stopCompose",
1818
"remoteUser": "node",
19-
// Forward the host's GITHUB_TOKEN into the container. Under agents:2, gh
20-
// authenticates from this token rather than a persisted login. On the host,
21-
// export GITHUB_TOKEN (e.g. from 1Password) before launching VS Code. See
22-
// https://github.com/rocicorp/devcontainer-features#gh-auth-via-1password-no-host-side-credentials
23-
"remoteEnv": {
24-
"GITHUB_TOKEN": "${localEnv:GITHUB_TOKEN}"
25-
},
2619
"features": {
2720
// Shared rocicorp features (https://github.com/rocicorp/devcontainer-features):
28-
// - agents: Codex (pinned) + Claude Code + gh; persists the Claude login
29-
// across rebuilds; gh uses the forwarded GITHUB_TOKEN.
21+
// - agents: Codex (pinned) + Claude Code; persists the Claude login
22+
// across rebuilds.
3023
// - pnpm: corepack-managed pnpm; removes npm/npx to enforce pnpm.
31-
"ghcr.io/rocicorp/devcontainer-features/agents:2": {},
24+
"ghcr.io/rocicorp/devcontainer-features/agents:3": {},
3225
"ghcr.io/rocicorp/devcontainer-features/pnpm:1": {}
3326
},
3427
"postCreateCommand": "pnpm install"

.github/dependabot.yml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
version: 2
2+
updates:
3+
- package-ecosystem: "devcontainers"
4+
directory: "/"
5+
schedule:
6+
interval: "weekly"
7+
groups:
8+
devcontainer-features:
9+
patterns: ["*"]

0 commit comments

Comments
 (0)