Skip to content

fix(quarto-cli): simplify installation log of tinytex and chromium #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eitsupi merged 3 commits into from
May 24, 2025
Merged

fix(quarto-cli): simplify installation log of tinytex and chromium #260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a72ddfc
fix(quarto-cli): simplify installation log of tinytex and chromium
eitsupi May 24, 2025
944d30b
fix(quarto-cli): message improve
eitsupi May 24, 2025
5dab02f
chore(quarto-cli): bump version
eitsupi May 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/quarto-cli/devcontainer-feature.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "Quarto CLI",
"id": "quarto-cli",
"version": "1.1.3",
"version": "1.1.4",
"description": "Installs the Quarto CLI. Auto-detects latest version.",
"documentationURL": "https://github.com/rocker-org/devcontainer-features/tree/main/src/quarto-cli",
"options": {
Expand Down
9 changes: 6 additions & 3 deletions src/quarto-cli/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,14 +133,17 @@ install_cli "${CLI_VERSION}"
if [ "${INSTALL_TINYTEX}" = "true" ]; then
echo "Installing TinyTeX..."
check_packages libfontconfig
su "${USERNAME}" -c 'quarto install tinytex'
su "${USERNAME}" -c 'quarto install tinytex --quiet'
echo "TinyTeX installation complete."
fi

if [ "${INSTALL_CHROMIUM}" = "true" ]; then
echo "Installing chromium..."
echo "(!) Quarto CLI installs headless Chromium via Puppeteer. The bundled Chromium that Puppeteer installs may not work on Docker containers."
echo "(!) Quarto CLI installs headless Chromium via Puppeteer."
echo " The bundled Chromium that Puppeteer installs may not work on Docker containers."
echo " Please check the Puppeteer document: <https://pptr.dev/troubleshooting#running-puppeteer-in-docker>"
su "${USERNAME}" -c 'quarto install chromium'
su "${USERNAME}" -c 'quarto install chromium --quiet'
echo "Chromium installation complete."
fi

# Clean up
Expand Down