Skip to content

fix(miniforge): exclude pre-releases from latest #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eitsupi merged 3 commits into from
Mar 17, 2026
Merged

fix(miniforge): exclude pre-releases from latest #275

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
306c85c
Fetch "latest" version from GitHub API excluding pre-releases
aryarm Mar 12, 2026
0d02cec
try to avoid rate limits as much as possible (#1)
aryarm Mar 13, 2026
2edad3f
update patch version of miniforge to 2.0.2
aryarm Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/miniforge/devcontainer-feature.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "Conda, Mamba (Miniforge)",
"id": "miniforge",
"version": "2.0.1",
"version": "2.0.2",
"description": "Installs Conda and Mamba package manager and Python3. conda-forge set as the default (and only) channel.",
"documentationURL": "https://github.com/rocker-org/devcontainer-features/tree/main/src/miniforge",
"options": {
Expand Down
26 changes: 20 additions & 6 deletions src/miniforge/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ elif [ "${USERNAME}" = "none" ] || ! id -u "${USERNAME}" >/dev/null 2>&1; then
fi

apt_get_update() {
if [ "$(find /var/lib/apt/lists/* | wc -l)" = "0" ]; then
if [ ! -d /var/lib/apt/lists ] || [ -z "$(ls -A /var/lib/apt/lists 2>/dev/null)" ]; then
echo "Running apt-get update..."
apt-get update -y
fi
Expand Down Expand Up @@ -87,12 +87,26 @@ find_version_from_git_tags() {
check_packages ca-certificates
version_list="$(git ls-remote --tags "${repository}" | grep -oP "${regex}" | tr -d ' ' | tr "${separator}" "." | sort -rV)"
if [ "${requested_version}" = "latest" ] || [ "${requested_version}" = "current" ] || [ "${requested_version}" = "lts" ]; then
declare -g "${variable_name}"="$(echo "${version_list}" | head -n 1)"
else
set +e
declare -g "${variable_name}"="$(echo "${version_list}" | grep -E -m 1 "^${requested_version//./\\.}([\\.\\s]|$)")"
set -e
requested_version=""
if [ "${repository}" = "https://github.com/conda-forge/miniforge" ]; then
check_packages curl
github_api_headers=()
if [ -n "${GITHUB_TOKEN:-}" ]; then
# use GITHUB_TOKEN to raise rate limits
github_api_headers=(-H "Authorization: Bearer ${GITHUB_TOKEN}" -H "X-GitHub-Api-Version: 2022-11-28")
fi
set +e
requested_version="$(curl -fsSL "${github_api_headers[@]}" "https://api.github.com/repos/conda-forge/miniforge/releases/latest" | sed -nE 's/^[[:space:]]*"tag_name":[[:space:]]*"([^"]+)".*/\1/p')"
set -e
fi
# fallback to most recent git tag if rate limit exceeded; this may unfortunately include pre-releases
if [ -z "${requested_version}" ]; then
requested_version="$(echo "${version_list}" | head -n 1)"
fi
fi
set +e
declare -g "${variable_name}"="$(echo "${version_list}" | grep -E -m 1 "^${requested_version//./\\.}([\\.\\s]|$)")"
set -e
fi
if [ -z "${!variable_name}" ] || ! echo "${version_list}" | grep "^${!variable_name//./\\.}$" >/dev/null 2>&1; then
echo -e "Invalid ${variable_name} value: ${requested_version}\nValid values:\n${version_list}" >&2
Expand Down
Loading