Merge pull request #1803 from rocket-admin/backend_typescript_improvements

Backend typescript improvements

Author: Artuomka

.github/workflows/code-quality.yml

@@ -40,3 +40,6 @@ jobs:
       - name: Run Biome
         if: steps.changed.outputs.files != ''
         run: biome ci --formatter-enabled=false --assist-enabled=false ${{ steps.changed.outputs.files }}
+      - name: Typecheck backend
+        if: steps.changed.outputs.files != ''
+        run: pnpm --filter ./backend typecheck

backend/package.json

@@ -9,6 +9,8 @@
 	"scripts": {
 		"prebuild": "rimraf dist",
 		"build": "nest build",
+		"typecheck": "tsc --noEmit --incremental false -p tsconfig.src.json && tsc --noEmit --incremental false -p tsconfig.json",
+		"lint": "biome lint src test",
 		"start": "nest start",
 		"start:dev": "nest start --watch --preserveWatchOutput",
 		"start:debug": "nest start --debug --watch",

backend/src/entities/ai/ai.service.ts

@@ -5,6 +5,7 @@ import { cleanAIJsonResponse } from '../../ai-core/tools/query-validators.js';
 import { QueryOrderingEnum } from '../../enums/query-ordering.enum.js';
 import { WidgetTypeEnum } from '../../enums/widget-type.enum.js';
 import { checkFieldAutoincrement } from '../../helpers/check-field-autoincrement.js';
+import { getErrorMessage } from '../../helpers/get-error-message.js';
 import { TableSettingsEntity } from '../table-settings/common-table-settings/table-settings.entity.js';
 import { TableWidgetEntity } from '../widget/table-widget.entity.js';
 import { TableInformation } from './ai-data-entities/types/ai-module-types.js';
@@ -78,13 +79,13 @@ export class AiService {
 				const batchSettings = await this.processTablesBatch(batch);
 				allSettings.push(...batchSettings);
 			} catch (error) {
-				console.warn(`Batch processing failed, falling back to individual table processing: ${error.message}`);
+				console.warn(`Batch processing failed, falling back to individual table processing: ${getErrorMessage(error)}`);
 				for (const tableInfo of batch) {
 					try {
 						const singleTableSettings = await this.processTablesBatch([tableInfo]);
 						allSettings.push(...singleTableSettings);
 					} catch (singleError) {
-						console.error(`Error processing AI for table "${tableInfo.table_name}": ${singleError.message}`);
+						console.error(`Error processing AI for table "${tableInfo.table_name}": ${getErrorMessage(singleError)}`);
 					}
 				}
 			}
@@ -289,7 +290,7 @@ IMPORTANT:
 		try {
 			return JSON.parse(cleanedResponse) as AIResponse;
 		} catch (error) {
-			throw new Error(`Failed to parse AI response for tables [${tableNames.join(', ')}]: ${error.message}`);
+			throw new Error(`Failed to parse AI response for tables [${tableNames.join(', ')}]: ${getErrorMessage(error)}`);
 		}
 	}
 

backend/src/entities/ai/use-cases/request-info-from-table-with-ai-v7.use.case.ts

@@ -115,7 +115,7 @@ export class RequestInfoFromTableWithAIUseCaseV7
 
 			response.end();
 		} catch (error) {
-			await slackPostMessage(error?.message);
+			await slackPostMessage((error as Error)?.message);
 			Sentry.captureException(error);
 			if (!response.headersSent) {
 				response.status(500).send({ error: 'An error occurred while processing your request.' });
@@ -192,7 +192,7 @@ export class RequestInfoFromTableWithAIUseCaseV7
 
 				depth++;
 			} catch (loopError) {
-				this.logger.error(`Error in tool loop at depth ${depth + 1}: ${loopError.message}`);
+				this.logger.error(`Error in tool loop at depth ${depth + 1}: ${(loopError as Error).message}`);
 				throw loopError;
 			}
 		}
@@ -290,8 +290,9 @@ export class RequestInfoFromTableWithAIUseCaseV7
 						result = encodeError({ error: `Unknown tool: ${toolCall.name}` });
 				}
 			} catch (error) {
-				this.logger.error(`Tool call ${toolCall.name} (${toolCall.id}) failed: ${error.message}`);
-				result = encodeError({ error: error.message });
+				const errMessage = (error as Error).message;
+				this.logger.error(`Tool call ${toolCall.name} (${toolCall.id}) failed: ${errMessage}`);
+				result = encodeError({ error: errMessage });
 			}
 
 			results.push({ toolCallId: toolCall.id, result });

backend/src/entities/cedar-authorization/cedar-authorization.service.ts

@@ -185,7 +185,7 @@ export class CedarAuthorizationService implements ICedarAuthorizationService, On
 				resource: { type: 'RocketAdmin::Connection', id: 'test' },
 				context: {},
 				policies: { staticPolicies: 'permit(principal, action, resource);' },
-				entities: [],
+				entities: [] as unknown[],
 				schema: schema,
 			};
 			const result = cedarWasm.isAuthorized(testCall as Parameters<typeof cedarWasm.isAuthorized>[0]);
@@ -198,7 +198,7 @@ export class CedarAuthorizationService implements ICedarAuthorizationService, On
 			}
 		} catch (e) {
 			if (e instanceof HttpException) throw e;
-			throw new HttpException({ message: `Invalid cedar schema: ${e.message}` }, HttpStatus.BAD_REQUEST);
+			throw new HttpException({ message: `Invalid cedar schema: ${(e as Error).message}` }, HttpStatus.BAD_REQUEST);
 		}
 	}
 
@@ -291,12 +291,12 @@ export class CedarAuthorizationService implements ICedarAuthorizationService, On
 				resource: { type: 'RocketAdmin::Connection', id: 'test' },
 				context: {},
 				policies: { staticPolicies: policyText },
-				entities: [],
+				entities: [] as unknown[],
 				schema: this.schema,
 			};
 			cedarWasm.isAuthorized(testCall as Parameters<typeof cedarWasm.isAuthorized>[0]);
 		} catch (e) {
-			throw new HttpException({ message: `Invalid cedar policy: ${e.message}` }, HttpStatus.BAD_REQUEST);
+			throw new HttpException({ message: `Invalid cedar policy: ${(e as Error).message}` }, HttpStatus.BAD_REQUEST);
 		}
 	}
 

backend/src/entities/cedar-authorization/cedar-schema.ts

@@ -2,7 +2,7 @@ export const CEDAR_SCHEMA = {
 	RocketAdmin: {
 		entityTypes: {
 			User: {
-				memberOfTypes: [],
+				memberOfTypes: [] as string[],
 				shape: {
 					type: 'Record',
 					attributes: {
@@ -11,7 +11,7 @@ export const CEDAR_SCHEMA = {
 				},
 			},
 			Group: {
-				memberOfTypes: [],
+				memberOfTypes: [] as string[],
 				shape: {
 					type: 'Record',
 					attributes: {
@@ -21,7 +21,7 @@ export const CEDAR_SCHEMA = {
 				},
 			},
 			Connection: {
-				memberOfTypes: [],
+				memberOfTypes: [] as string[],
 				shape: {
 					type: 'Record',
 					attributes: {},

backend/src/entities/connection/use-cases/find-all-connections.use.case.ts

@@ -110,7 +110,7 @@ export class FindAllConnectionsUseCase
 			return Object.keys(connection).reduce((acc, key) => {
 				if (allowedKeys.includes(key)) {
 					// eslint-disable-next-line security/detect-object-injection
-					acc[key] = connection[key];
+					(acc as Record<string, unknown>)[key] = (connection as unknown as Record<string, unknown>)[key];
 				}
 				return acc;
 			}, {} as FilteredConnection);

backend/src/entities/connection/use-cases/find-one-connection.use.case.ts

@@ -67,7 +67,7 @@ export class FindOneConnectionUseCase
 			return Object.keys(connection).reduce((acc, key) => {
 				if (allowedKeys.includes(key)) {
 					// eslint-disable-next-line security/detect-object-injection
-					acc[key] = connection[key];
+					(acc as Record<string, unknown>)[key] = (connection as unknown as Record<string, unknown>)[key];
 				}
 				return acc;
 			}, {} as FilteredConnection);

backend/src/entities/connection/use-cases/get-connection-diagram.use.case.ts

@@ -52,7 +52,7 @@ export class GetConnectionDiagramUseCase
 		try {
 			tables = await dao.getTablesFromDB(userEmail);
 		} catch (e) {
-			throw new UnknownSQLException(e.message, ExceptionOperations.FAILED_TO_GET_TABLES);
+			throw new UnknownSQLException((e as Error).message, ExceptionOperations.FAILED_TO_GET_TABLES);
 		}
 
 		const realTables = tables.filter((t) => !t.isView);

backend/src/entities/connection/use-cases/preview-connection-diagram.use.case.ts

@@ -53,7 +53,7 @@ export class PreviewConnectionDiagramUseCase
 		try {
 			tables = await dao.getTablesFromDB(userEmail);
 		} catch (e) {
-			throw new UnknownSQLException(e.message, ExceptionOperations.FAILED_TO_GET_TABLES);
+			throw new UnknownSQLException((e as Error).message, ExceptionOperations.FAILED_TO_GET_TABLES);
 		}
 
 		const realTables = tables.filter((t) => !t.isView);