remove viewing secrets

Author: gugu

backend/src/entities/user-secret/application/data-structures/found-secret.ds.ts

@@ -1,7 +1,6 @@
 export class FoundSecretDS {
   id: string;
   slug: string;
-  value?: string;
   companyId: string;
   createdAt: Date;
   updatedAt: Date;

backend/src/entities/user-secret/application/data-structures/get-secret.ds.ts

@@ -1,5 +1,4 @@
 export class GetSecretDS {
   userId: string;
   slug: string;
-  masterPassword?: string;
 }

backend/src/entities/user-secret/application/dto/found-secret.dto.ts

@@ -15,14 +15,6 @@ export class FoundSecretDto {
   })
   slug: string;
 
-  @ApiProperty({
-    type: String,
-    required: false,
-    description: 'Decrypted secret value (only included when retrieving a specific secret)',
-    example: 'my-secret-value-123',
-  })
-  value?: string;
-
   @ApiProperty({
     type: String,
     description: 'Company ID that owns this secret',

backend/src/entities/user-secret/use-cases/get-secret-by-slug.use.case.ts

@@ -1,13 +1,11 @@
-import { ForbiddenException, GoneException, Inject, Injectable, NotFoundException, Scope } from '@nestjs/common';
+import { GoneException, Inject, Injectable, NotFoundException, Scope } from '@nestjs/common';
 import AbstractUseCase from '../../../common/abstract-use.case.js';
 import { BaseType } from '../../../common/data-injection.tokens.js';
 import { IGlobalDatabaseContext } from '../../../common/application/global-database-context.interface.js';
 import { GetSecretDS } from '../application/data-structures/get-secret.ds.js';
 import { FoundSecretDS } from '../application/data-structures/found-secret.ds.js';
 import { IGetSecretBySlug } from './user-secret-use-cases.interface.js';
 import { buildFoundSecretDS } from '../utils/build-found-secret.ds.js';
-import { Encryptor } from '../../../helpers/encryption/encryptor.js';
-import { SecretActionEnum } from '../../secret-access-log/secret-access-log.entity.js';
 import { Messages } from '../../../exceptions/text/messages.js';
 
 @Injectable({ scope: Scope.REQUEST })
@@ -20,7 +18,7 @@ export class GetSecretBySlugUseCase extends AbstractUseCase<GetSecretDS, FoundSe
   }
 
   protected async implementation(inputData: GetSecretDS): Promise<FoundSecretDS> {
-    const { userId, slug, masterPassword } = inputData;
+    const { userId, slug } = inputData;
 
     const user = await this._dbContext.userRepository.findOne({
       where: { id: userId },
@@ -41,35 +39,6 @@ export class GetSecretBySlugUseCase extends AbstractUseCase<GetSecretDS, FoundSe
       throw new GoneException(Messages.SECRET_EXPIRED);
     }
 
-    if (secret.masterEncryption && !masterPassword) {
-      throw new ForbiddenException(Messages.SECRET_MASTER_PASSWORD_REQUIRED);
-    }
-
-    if (secret.masterEncryption && masterPassword) {
-      const isValid = await Encryptor.verifyUserPassword(masterPassword, secret.masterHash);
-      if (!isValid) {
-        await this._dbContext.secretAccessLogRepository.createAccessLog(
-          secret.id,
-          userId,
-          SecretActionEnum.VIEW,
-          false,
-          Messages.SECRET_MASTER_PASSWORD_INVALID,
-        );
-        throw new ForbiddenException(Messages.SECRET_MASTER_PASSWORD_INVALID);
-      }
-    }
-
-    secret.lastAccessedAt = new Date();
-    await this._dbContext.userSecretRepository.save(secret);
-
-    await this._dbContext.secretAccessLogRepository.createAccessLog(secret.id, userId, SecretActionEnum.VIEW);
-
-    let decryptedValue = Encryptor.decryptData(secret.encryptedValue);
-
-    if (secret.masterEncryption && masterPassword) {
-      decryptedValue = Encryptor.decryptDataMasterPwd(decryptedValue, masterPassword);
-    }
-
-    return buildFoundSecretDS(secret, decryptedValue);
+    return buildFoundSecretDS(secret);
   }
 }

backend/src/entities/user-secret/user-secret.controller.ts

@@ -128,13 +128,9 @@ export class UserSecretController {
   @ApiOperation({ summary: 'Get secret by slug' })
   @ApiResponse({
     status: 200,
-    description: 'Returns secret details with decrypted value.',
+    description: 'Returns secret metadata (value is never exposed).',
     type: FoundSecretDto,
   })
-  @ApiResponse({
-    status: 403,
-    description: 'Master password required or incorrect.',
-  })
   @ApiResponse({
     status: 404,
     description: 'Secret or user not found.',
@@ -146,15 +142,10 @@ export class UserSecretController {
   @ApiParam({ name: 'slug', type: String, description: 'Unique secret identifier', example: 'database-password' })
   @UseGuards(CompanyUserGuard)
   @Get('/secrets/:slug')
-  async getSecretBySlug(
-    @UserId() userId: string,
-    @Param('slug') slug: string,
-    @MasterPassword() masterPassword?: string,
-  ): Promise<FoundSecretDto> {
+  async getSecretBySlug(@UserId() userId: string, @Param('slug') slug: string): Promise<FoundSecretDto> {
     const foundSecret = await this.getSecretBySlugUseCase.execute({
       userId,
       slug,
-      masterPassword,
     });
     return buildFoundSecretDto(foundSecret);
   }

backend/src/entities/user-secret/utils/build-created-secret.dto.ts

@@ -5,7 +5,6 @@ export function buildCreatedSecretDto(ds: CreatedSecretDS): FoundSecretDto {
   return {
     id: ds.id,
     slug: ds.slug,
-    value: undefined,
     companyId: ds.companyId,
     createdAt: ds.createdAt,
     updatedAt: ds.updatedAt,

backend/src/entities/user-secret/utils/build-found-secret.ds.ts

@@ -1,11 +1,10 @@
 import { FoundSecretDS } from '../application/data-structures/found-secret.ds.js';
 import { UserSecretEntity } from '../user-secret.entity.js';
 
-export function buildFoundSecretDS(secret: UserSecretEntity, decryptedValue?: string): FoundSecretDS {
+export function buildFoundSecretDS(secret: UserSecretEntity): FoundSecretDS {
   return {
     id: secret.id,
     slug: secret.slug,
-    value: decryptedValue,
     companyId: secret.companyId,
     createdAt: secret.createdAt,
     updatedAt: secret.updatedAt,

backend/src/entities/user-secret/utils/build-found-secret.dto.ts

@@ -5,7 +5,6 @@ export function buildFoundSecretDto(ds: FoundSecretDS): FoundSecretDto {
   return {
     id: ds.id,
     slug: ds.slug,
-    value: ds.value,
     companyId: ds.companyId,
     createdAt: ds.createdAt,
     updatedAt: ds.updatedAt,

backend/src/entities/user-secret/utils/build-updated-secret.dto.ts

@@ -5,7 +5,6 @@ export function buildUpdatedSecretDto(ds: UpdatedSecretDS): FoundSecretDto {
   return {
     id: ds.id,
     slug: ds.slug,
-    value: undefined,
     companyId: ds.companyId,
     createdAt: ds.createdAt,
     updatedAt: ds.updatedAt,

frontend/src/app/components/secrets/edit-secret-dialog/edit-secret-dialog.component.css

@@ -14,68 +14,7 @@ mat-dialog-content {
     margin-bottom: 16px;
 }
 
-.loading-container {
-    display: flex;
-    flex-direction: column;
-    align-items: center;
-    justify-content: center;
-    padding: 40px;
-    text-align: center;
-}
-
-.loading-container p {
-    margin-top: 16px;
-    color: rgba(0, 0, 0, 0.54);
-}
-
-@media (prefers-color-scheme: dark) {
-    .loading-container p {
-        color: rgba(255, 255, 255, 0.54);
-    }
-}
-
-.master-password-container {
-    display: flex;
-    flex-direction: column;
-    align-items: center;
-    text-align: center;
-    padding: 24px;
-}
-
-.lock-icon {
-    font-size: 48px;
-    width: 48px;
-    height: 48px;
-    color: #1976d2;
-    margin-bottom: 16px;
-}
-
-@media (prefers-color-scheme: dark) {
-    .lock-icon {
-        color: #64b5f6;
-    }
-}
-
-.master-password-container h3 {
-    margin: 0 0 8px 0;
-}
-
-.master-password-container p {
-    color: rgba(0, 0, 0, 0.54);
-    margin: 0 0 24px 0;
-}
-
-@media (prefers-color-scheme: dark) {
-    .master-password-container p {
-        color: rgba(255, 255, 255, 0.54);
-    }
-}
-
-.expiration-section {
-    margin-bottom: 16px;
-}
-
-.encryption-note {
+.info-note {
     display: flex;
     align-items: flex-start;
     gap: 8px;
@@ -84,19 +23,34 @@ mat-dialog-content {
     border-radius: 8px;
     color: #1565c0;
     font-size: 14px;
-    margin-top: 16px;
+    margin-bottom: 20px;
 }
 
-.encryption-note mat-icon {
+.info-note mat-icon {
     font-size: 20px;
     width: 20px;
     height: 20px;
     flex-shrink: 0;
 }
 
 @media (prefers-color-scheme: dark) {
-    .encryption-note {
+    .info-note {
         background-color: rgba(100, 181, 246, 0.15);
         color: #64b5f6;
     }
 }
+
+.expiration-section {
+    margin-bottom: 16px;
+}
+
+.master-password-section {
+    margin-top: 16px;
+}
+
+.master-password-error {
+    color: #f44336;
+    font-size: 12px;
+    margin-top: -12px;
+    margin-bottom: 8px;
+}