Skip to content

Commit b180132

Browse files
Merge pull request #1139 from rocket-admin/fixes
company: fix company observable
2 parents 45927f5 + cd3f3ac commit b180132

5 files changed

Lines changed: 24 additions & 20 deletions

File tree

frontend/src/app/components/company/company.component.ts

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,33 +1,33 @@
1+
import { Angulartics2, Angulartics2OnModule } from 'angulartics2';
2+
import { CUSTOM_ELEMENTS_SCHEMA, Component } from '@angular/core';
13
import { Company, CompanyMember, CompanyMemberRole } from 'src/app/models/company';
24

3-
import { Angulartics2, Angulartics2OnModule } from 'angulartics2';
5+
import { AlertComponent } from '../ui-components/alert/alert.component';
46
import { CompanyService } from 'src/app/services/company.service';
5-
import { Component, CUSTOM_ELEMENTS_SCHEMA } from '@angular/core';
7+
import { DeleteDomainDialogComponent } from './delete-domain-dialog/delete-domain-dialog.component';
68
import { DeleteMemberDialogComponent } from './delete-member-dialog/delete-member-dialog.component';
9+
import { FormsModule } from '@angular/forms';
710
import { InviteMemberDialogComponent } from './invite-member-dialog/invite-member-dialog.component';
11+
import { MatButtonModule } from '@angular/material/button';
812
import { MatDialog } from '@angular/material/dialog';
9-
import { RevokeInvitationDialogComponent } from './revoke-invitation-dialog/revoke-invitation-dialog.component';
10-
import { SubscriptionPlans } from 'src/app/models/user';
11-
import { UserService } from 'src/app/services/user.service';
12-
import { environment } from 'src/environments/environment';
13-
import { orderBy } from "lodash";
14-
import { FormsModule } from '@angular/forms';
1513
import { MatFormFieldModule } from '@angular/material/form-field';
16-
import { MatInputModule } from '@angular/material/input';
17-
import { MatButtonModule } from '@angular/material/button';
1814
import { MatIconModule } from '@angular/material/icon';
15+
import { MatInputModule } from '@angular/material/input';
1916
import { MatSelectModule } from '@angular/material/select';
2017
import { MatSlideToggleModule } from '@angular/material/slide-toggle';
21-
import { MatTooltipModule } from '@angular/material/tooltip';
2218
import { MatTableModule } from '@angular/material/table';
23-
import { AlertComponent } from '../ui-components/alert/alert.component';
19+
import { MatTooltipModule } from '@angular/material/tooltip';
20+
import { NgIf } from '@angular/common';
2421
import { PlaceholderCompanyComponent } from '../skeletons/placeholder-company/placeholder-company.component';
2522
import { PlaceholderTableDataComponent } from '../skeletons/placeholder-table-data/placeholder-table-data.component';
26-
import { NgIf } from '@angular/common';
23+
import { RevokeInvitationDialogComponent } from './revoke-invitation-dialog/revoke-invitation-dialog.component';
2724
import { RouterModule } from '@angular/router';
28-
import { DeleteDomainDialogComponent } from './delete-domain-dialog/delete-domain-dialog.component';
29-
import { Title } from '@angular/platform-browser';
3025
import { Subscription } from 'rxjs';
26+
import { SubscriptionPlans } from 'src/app/models/user';
27+
import { Title } from '@angular/platform-browser';
28+
import { UserService } from 'src/app/services/user.service';
29+
import { environment } from 'src/environments/environment';
30+
import { orderBy } from "lodash";
3131

3232
@Component({
3333
selector: 'app-company',

frontend/src/app/components/connections-list/connections-list.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,7 @@ <h2 class="connectionInfo__connectionTitle">{{ titles[connectionItem.connection.
194194
</button>
195195

196196
<div [ngClass]="connections.length ? 'fabActions' : null">
197-
<a routerLink="/zapier" *ngIf="connections.length && (currentUser.role === 'ADMIN' || currentUser.role === 'DB_ADMIN')" class="zapier-link">
197+
<a routerLink="/zapier" *ngIf="connections.length" class="zapier-link">
198198
<svg class="zapier-link__logo" width="401" height="400" viewBox="0 0 401 400" fill="none" xmlns="http://www.w3.org/2000/svg">
199199
<rect x="0.526367" width="400" height="400" fill="#FF4F00"/>
200200
<rect x="0.526367" width="400" height="400" rx="200" fill="#FF4F00"/>

frontend/src/app/components/dashboard/dashboard.component.css

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,8 @@
9494
}
9595

9696
.alerts {
97+
display: flex;
98+
flex-direction: column;
9799
margin-top: 24px;
98100
}
99101

frontend/src/app/components/dashboard/db-tables-data-source.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -236,7 +236,7 @@ export class TablesDataSource implements DataSource<Object> {
236236
.reduce((normalizedColumns, column) => (normalizedColumns[column.title] = column.normalizedTitle, normalizedColumns), {})
237237
this.displayedDataColumns = (filter(this.columns, column => column.selected === true)).map(column => column.title);
238238
this.permissions = res.table_permissions.accessLevel;
239-
if (this.keyAttributes.length && this.permissions.edit || this.permissions.delete) {
239+
if (this.keyAttributes.length && (this.permissions.edit || this.permissions.delete)) {
240240
this.actionsColumnWidth = this.getActionsColumnWidth(this.tableActions, this.permissions);
241241
this.displayedColumns = ['select', ...this.displayedDataColumns, 'actions'];
242242
} else {

frontend/src/app/services/company.service.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
import { AlertActionType, AlertType } from '../models/alert';
2+
import { BehaviorSubject, EMPTY } from 'rxjs';
23
import { catchError, map } from 'rxjs/operators';
34

45
import { CompanyMemberRole } from '../models/company';
5-
import { BehaviorSubject, EMPTY } from 'rxjs';
6+
import { ConfigurationService } from './configuration.service';
67
import { HttpClient } from '@angular/common/http';
78
import { Injectable } from '@angular/core';
89
import { NotificationsService } from './notifications.service';
9-
import { ConfigurationService } from './configuration.service';
1010

1111
@Injectable({
1212
providedIn: 'root'
@@ -458,9 +458,11 @@ export class CompanyService {
458458
} else {
459459
this.companyTabTitle = null;
460460
}
461-
461+
462462
this.companyTabTitleSubject.next(res.tab_title);
463463

464+
this.company.next('');
465+
464466
return {
465467
logo: this.companyLogo,
466468
favicon: this.companyFavicon,

0 commit comments

Comments
 (0)