Skip to content

Commit b6a14ea

Browse files
Merge pull request #1747 from rocket-admin/mini-fixes
table view: fix link clicks on table rows and change icon on Settings button
2 parents 45bdcb6 + 26c289c commit b6a14ea

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

frontend/src/app/components/dashboard/db-table-view/db-table-view.component.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@ <h2 class="mat-h2 table-name">{{ displayName }}</h2>
152152
angulartics2On="click"
153153
angularticsAction="Dashboard: settings dropdown is clicked"
154154
(click)="posthog.capture('Dashboard: settings dropdown is clicked')">
155-
<mat-icon>more_vert</mat-icon>
155+
<mat-icon fontSet="material-symbols-outlined">settings</mat-icon>
156156
</button>
157157
<mat-menu #settingsMenu="matMenu">
158158
<a mat-menu-item *ngIf="tableData"
@@ -352,7 +352,7 @@ <h2 class="mat-h2 table-name">{{ displayName }}</h2>
352352
angulartics2On="click"
353353
angularticsAction="Dashboard: edit row is clicked"
354354
matTooltip="Edit row"
355-
(click)="stashUrlParams(); posthog.capture('Dashboard: edit row is clicked')">
355+
(click)="$event.stopPropagation(); stashUrlParams(); posthog.capture('Dashboard: edit row is clicked')">
356356
<mat-icon fontSet="material-symbols-outlined">create</mat-icon>
357357
</a>
358358
<a mat-icon-button *ngIf="canAddRow()"
@@ -365,7 +365,7 @@ <h2 class="mat-h2 table-name">{{ displayName }}</h2>
365365
angulartics2On="click"
366366
angularticsAction="Dashboard: duplicate row is clicked"
367367
matTooltip="Duplicate row"
368-
(click)="stashUrlParams(); posthog.capture('Dashboard: duplicate row is clicked')">
368+
(click)="$event.stopPropagation(); stashUrlParams(); posthog.capture('Dashboard: duplicate row is clicked')">
369369
<mat-icon fontSet="material-symbols-outlined">difference</mat-icon>
370370
</a>
371371
<button type="button" mat-icon-button *ngIf="canDeleteRow() && tableData.canDelete"

0 commit comments

Comments
 (0)